Skip to content

Change Logger to start transition to Sendables#11

Open
TheBitEffect wants to merge 15 commits into
masterfrom
sendable-logging
Open

Change Logger to start transition to Sendables#11
TheBitEffect wants to merge 15 commits into
masterfrom
sendable-logging

Conversation

@TheBitEffect
Copy link
Copy Markdown
Contributor

WPILib is now including a much easier way to have classes interact with SmartDashboard. While there is no on-bot logging (yet), having WPILib handle the outputting of variables to SmartDashboard and having the ability to change values from the driver station on-the-fly might be beneficial.

@TheBitEffect TheBitEffect self-assigned this Jan 24, 2022
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Loggable.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java
Comment thread src/main/java/frc/robot/logging/Logger.java
Comment thread src/main/java/frc/robot/logging/Logger.java
Comment thread src/main/java/frc/robot/logging/Logger.java
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Loggable.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 29, 2022

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 16.33%. Comparing base (cee37a9) to head (fbbc581).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/frc/robot/logging/Logger.java 0.00% 37 Missing ⚠️
...ain/java/frc/robot/logging/LoggableCompressor.java 0.00% 1 Missing ⚠️
...a/frc/robot/logging/LoggablePowerDistribution.java 0.00% 1 Missing ⚠️
src/main/java/frc/robot/logging/LoggableTimer.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
- Coverage     17.78%   16.33%   -1.46%     
  Complexity       17       17              
============================================
  Files            13       13              
  Lines           371      404      +33     
  Branches         25       32       +7     
============================================
  Hits             66       66              
- Misses          305      338      +33     
Files with missing lines Coverage Δ
...ain/java/frc/robot/logging/LoggableCompressor.java 0.00% <0.00%> (ø)
...a/frc/robot/logging/LoggablePowerDistribution.java 0.00% <0.00%> (ø)
src/main/java/frc/robot/logging/LoggableTimer.java 0.00% <0.00%> (ø)
src/main/java/frc/robot/logging/Logger.java 0.00% <0.00%> (ø)

Impacted file tree graph

Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
Comment thread src/main/java/frc/robot/logging/Logger.java Outdated
@TheBitEffect
Copy link
Copy Markdown
Contributor Author

CodeClimate is just complaining about Javadoc formatting, not using an external logging library and code duplication that @tricktrap and I have decided would leave the code clearer to ignore. I will fix the Javadocs later tonight, but other than that, I do believe that this is ready for review.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit fbbc581 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 16.3% (-1.3% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants