Added tests for most of the methods in FunctionUtil.#5957
Open
bubblobill wants to merge 3 commits intoRPTools:developfrom
Open
Added tests for most of the methods in FunctionUtil.#5957bubblobill wants to merge 3 commits intoRPTools:developfrom
bubblobill wants to merge 3 commits intoRPTools:developfrom
Conversation
better boolean recognition.
Collaborator
Author
|
Tests failing before fixes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #5956
closes #5956
Description of the Change
Missing tests for: i.e. I couldn't work out how to get them to fly.
Added tests for;
checkNumberParam()
delimitedResult()
getBooleanValue()
getPaintFromString()
paramAsBoolean()
paramAsString()
paramAsInteger()
paramAsDouble()
paramAsFloat()
paramAsBigDecimal()
paramFromStrPropOrJsonAsJsonObject()
paramAsJson()
paramAsJsonObject()
paramAsJsonArray()
paramConvertedToJsonArray()
paramConvertedToJson()
jsonWithLowerCaseKeys()
validateKeyNames()
Possible Drawbacks
Macros relying on dodgy flavours might fail the taste test, though unlikely.
Release Notes
Improved macro argument processing
This change is