Skip to content

Fix ListOf inheritance and compatibility of NamesProxy#1464

Open
Enchufa2 wants to merge 3 commits intomasterfrom
fix/1463
Open

Fix ListOf inheritance and compatibility of NamesProxy#1464
Enchufa2 wants to merge 3 commits intomasterfrom
fix/1463

Conversation

@Enchufa2
Copy link
Copy Markdown
Member

Closes #1463.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Copy Markdown
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- two comments inline.

@Enchufa2
Copy link
Copy Markdown
Member Author

Let's wait for a revdep also with this one just in case.

@eddelbuettel
Copy link
Copy Markdown
Member

Reverse depends started. I had locally rebased, so like this branch now now it incorporates the just-merged #1462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UB in ListOf proxies

3 participants