Conversation
eddelbuettel
left a comment
There was a problem hiding this comment.
Looks good to me. It will get in the queue of reverse depends runs to do.
Co-authored-by: Kevin Ushey <kevinushey@gmail.com>
Co-authored-by: Kevin Ushey <kevinushey@gmail.com>
|
This branch constantlty times out at GH when running the battery of Docker containers. That ... has never happened before. When I try to repro, I see so maybe one of these is regressing. An earlier one killed with 15 has but that may be due to having run two concurrently as root from the same directory. |
|
It is these two lines / this test: |
|
Good catch, fixed now! BTW, and it freezes instead of failing? It may be a tinytest bug, right? |
I am not sure. I actually first went that route as I know Mark just updated |
Closes #1465.
For promises, we have here a temporary workaround, but this is going to come back at us, because we are using a bunch of functions (
PRVALUE,PRENV...) that are not part of the API, even if we don't see a NOTE yet. The problem is that I don't see alternatives yet.Checklist
R CMD checkstill passes all tests