Set execute permission on scripts with shebangs#1467
Merged
eddelbuettel merged 1 commit intoRcppCore:masterfrom Apr 1, 2026
Merged
Set execute permission on scripts with shebangs#1467eddelbuettel merged 1 commit intoRcppCore:masterfrom
eddelbuettel merged 1 commit intoRcppCore:masterfrom
Conversation
Member
|
We tend not do the bulk whitespace change commits as they obfuscate |
eddelbuettel
approved these changes
Apr 1, 2026
Member
eddelbuettel
left a comment
There was a problem hiding this comment.
Looks good to me. I am indifferent on the overall merit but it won't do harm.
Enchufa2
approved these changes
Apr 1, 2026
Member
Enchufa2
left a comment
There was a problem hiding this comment.
RPM packaging complains about executables without shebang and shebangs without execution bit. So this just makes life downstream easier. :)
Member
|
I know, but it is still just a source property that has not bitten anyone in 15 years. Oh well. In it goes with dual approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
R CMD checkstill passes all tests