Skip to content

Find Spatial in spatial/, falling back to reactvisioncca/ - #439

Merged
doranteseduardo merged 1 commit into
developfrom
fix/spatial-folder
Oct 30, 2026
Merged

doranteseduardo merged 1 commit into
developfrom
fix/spatial-folder

Conversation

@doranteseduardo

Copy link
Copy Markdown
Member

Summary

The workspace now names Spatial's checkout spatial/ (workspace#2), and scripts/build.sh builds it from there. virocore still looked only for ../reactvisioncca, and both Android and iOS fall back silently to stub cloud anchors when the headers are missing, so a renamed checkout would build without Spatial and no error.

What's in it

  • Android (android/sharedCode/CMakeLists.txt): RVCCA_DIR is ../../../spatial, or ../../../reactvisioncca when only the old folder exists.
  • iOS (ViroRenderer.xcodeproj): HEADER_SEARCH_PATHS lists ../../spatial/include before ../../reactvisioncca/include, in both configurations.
  • Comments in VROCloudAnchorProviderReactVision.mm and build_visionos.sh name the new folder.

Notes

  • Nothing else changes: the library is still libreactvisioncca, and the prebuilts stay in ios/Libraries/reactvisioncca/.
  • The fallback keeps checkouts that have not renamed the folder building as before.

Testing

  • plutil -lint on the project file passes; CI builds Android and iOS.
  • After the merge, a full scripts/build.sh from the renamed spatial/ checkout, checking with scripts/verify_colocation_binaries.sh that the binaries carry Spatial, not the stubs.

Work by Ernesto, Benito and Eduardo.

@doranteseduardo
doranteseduardo merged commit 9b2b7aa into develop Oct 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants