Repository navigation
Find Spatial in spatial/, falling back to reactvisioncca/ - #439
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workspace now names Spatial's checkout
spatial/(workspace#2), andscripts/build.shbuilds it from there. virocore still looked only for../reactvisioncca, and both Android and iOS fall back silently to stub cloud anchors when the headers are missing, so a renamed checkout would build without Spatial and no error.What's in it
android/sharedCode/CMakeLists.txt):RVCCA_DIRis../../../spatial, or../../../reactvisionccawhen only the old folder exists.ViroRenderer.xcodeproj):HEADER_SEARCH_PATHSlists../../spatial/includebefore../../reactvisioncca/include, in both configurations.VROCloudAnchorProviderReactVision.mmandbuild_visionos.shname the new folder.Notes
libreactvisioncca, and the prebuilts stay inios/Libraries/reactvisioncca/.Testing
plutil -linton the project file passes; CI builds Android and iOS.scripts/build.shfrom the renamedspatial/checkout, checking withscripts/verify_colocation_binaries.shthat the binaries carry Spatial, not the stubs.Work by Ernesto, Benito and Eduardo.