Repository navigation
iOS: save downloads from signed URLs, and fail a download whose write… - #444
Merged
Merged
Conversation
… fails VROPlatformLastPathComponent names the temporary file a download is written to, and kept the URL's query. A signed URL's token pushed the name past the 255-byte file name limit, so writeToURL failed, and both download functions ignored that and reported success with a path to a file that did not exist. The name now drops the query and fragment, a failed write makes the synchronous download report failure, and the async one logs it and calls onFailure. ViroKit is not rebuilt in this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… fails
VROPlatformLastPathComponent names the temporary file a download is written to, and kept the URL's query. A signed URL's token pushed the name past the 255-byte file name limit, so writeToURL failed, and both download functions ignored that and reported success with a path to a file that did not exist. The name now drops the query and fragment, a failed write makes the synchronous download report failure, and the async one logs it and calls onFailure. ViroKit is not rebuilt in this commit.