Skip to content

ci: remove the benchmark workflow and the concurrency harness job - #141

Merged
ohaibbq merged 1 commit into
mainfrom
worktree-remove-bench-concurrency-workflows
Nov 13, 2026
Merged

ohaibbq merged 1 commit into
mainfrom
worktree-remove-bench-concurrency-workflows

Conversation

@ohaibbq

@ohaibbq ohaibbq commented Nov 13, 2026

Copy link
Copy Markdown
Member

Removes the benchmark workflow and the concurrency harness job from CI. No issue is linked; the maintainer requested this directly.

What changed

  • Deletes .github/workflows/bench.yml, which ran gsql-bench on pushes and bench-labeled PRs and charted the results on the benchmarks branch.
  • Deletes the concurrency-harness job from ci.yml. That job ran analyzer-threads, shared-catalog-threads, and grpc-smoke, so none of the three runs in CI after this merges.
  • Deletes the bench-x64 runner from .github/runs-on.yml; only bench.yml used it.

The README's CI table and docs/BUILD.md no longer say CI runs these. The zig build steps themselves are untouched and still run locally.

What BigQuery does / what the emulator did / spec cases

Not applicable. This changes CI configuration and docs only, with no emulator behavior change.

Follow-up outside this PR

  • The benchmarks branch and the bench label still exist on GitHub.
  • If concurrency harnesses or gsql-bench are required status checks in branch protection, they need removing there, or PRs will wait on them indefinitely.

Checks

Both edited YAML files parse, and nothing in the repo still references the removed workflow, job, or runner. I did not run the commands below locally because no Zig source changed; CI on this PR covers them.

  • zig build test
  • zig build test-server
  • zig build spec -- --strict
  • zig fmt --check build.zig entrypoints tools
  • ephor reports zero findings

🤖 Generated with Claude Code

Delete bench.yml and the concurrency-harness job in ci.yml, along with
the bench-x64 runner only bench.yml used. The zig build steps
(gsql-bench, analyzer-threads, shared-catalog-threads, grpc-smoke)
stay available locally.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>

@incidentist incidentist left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑️

@ohaibbq
ohaibbq merged commit 9d905c8 into main Nov 13, 2026
17 of 18 checks passed
@ohaibbq
ohaibbq deleted the worktree-remove-bench-concurrency-workflows branch November 13, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants