Repository navigation
ci: remove the benchmark workflow and the concurrency harness job - #141
Merged
Merged
Conversation
Delete bench.yml and the concurrency-harness job in ci.yml, along with the bench-x64 runner only bench.yml used. The zig build steps (gsql-bench, analyzer-threads, shared-catalog-threads, grpc-smoke) stay available locally. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the benchmark workflow and the concurrency harness job from CI. No issue is linked; the maintainer requested this directly.
What changed
.github/workflows/bench.yml, which rangsql-benchon pushes andbench-labeled PRs and charted the results on thebenchmarksbranch.concurrency-harnessjob fromci.yml. That job rananalyzer-threads,shared-catalog-threads, andgrpc-smoke, so none of the three runs in CI after this merges.bench-x64runner from.github/runs-on.yml; onlybench.ymlused it.The README's CI table and
docs/BUILD.mdno longer say CI runs these. Thezig buildsteps themselves are untouched and still run locally.What BigQuery does / what the emulator did / spec cases
Not applicable. This changes CI configuration and docs only, with no emulator behavior change.
Follow-up outside this PR
benchmarksbranch and thebenchlabel still exist on GitHub.concurrency harnessesorgsql-benchare required status checks in branch protection, they need removing there, or PRs will wait on them indefinitely.Checks
Both edited YAML files parse, and nothing in the repo still references the removed workflow, job, or runner. I did not run the commands below locally because no Zig source changed; CI on this PR covers them.
zig build testzig build test-serverzig build spec -- --strictzig fmt --check build.zig entrypoints tools🤖 Generated with Claude Code