ServerAddress Set by ClowdApp#1761
Open
mjholder wants to merge 3 commits intoRedHatInsights:masterfrom
Open
Conversation
Contributor
Author
|
/test-e2e |
JGiola
previously approved these changes
Apr 13, 2026
Contributor
Author
|
/test-e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://redhat.atlassian.net/browse/ENGPROD-9733
App-level trigger metadata now takes precedence over auto-injected env-level values. If the ClowdApp doesn't set a field, the env value fills in as a default. This applies to all trigger types (prometheus, kafka, etc.).
Kuttl test added: tests/kuttl/test-autoscaler-prometheus-app-serveraddress/ — verifies app-specified serverAddress is preserved and updates propagate to the ScaledObject.
This change came from a bug reported by the notifications team when trying to test auto scaling based on a different prometheus server. When they updated the clowdapp Notifications Engine's serverAddress, clowder reconciled the resources but did not actually apply the new address. So we are in a weird situation where the resource doesn't match the definition but clowder says everything is reconciled correctly.
Thread: https://redhat-internal.slack.com/archives/C07FQ00BJV8/p1774452941621759
Verification:
Deployed fixed Clowder to minikube, manual check confirmed ScaledObject now uses app-level serverAddress
New kuttl test: PASS
Existing tests (app-interface, status-only-update): PASS — no regressions