feat(h2c): adds support for setting target port#1763
Open
tonytheleg wants to merge 1 commit intoRedHatInsights:masterfrom
Open
feat(h2c): adds support for setting target port#1763tonytheleg wants to merge 1 commit intoRedHatInsights:masterfrom
tonytheleg wants to merge 1 commit intoRedHatInsights:masterfrom
Conversation
* adds new h2cTargetPort to ClowdApp spec for private and public * updates service creation to use the h2cTargetPort if set * defaults to using h2cPort value in ClowdEnv if not set (current) * adds new test to validate h2cTargetPort setting functionality * updates h2c appProtocl to correct kubernetes-specific value
986d0ea to
de4f14d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Why:
Related to #1414, Kessel leverages port 9000 for gRPC but by default, when enabling h2c in Clowder, the Kubernetes service mapping always matches the
h2cPortto the target port in the service. Instead of trying to move Kessel Inventory to a new port which would require a lot of updates across multiple teams, we'd like to abstract that problem by being able to override the target port via our ClowdApp.Validation (in minikube):