Skip to content

refactor(mcp): adopt shared primitives in Add/Edit source forms#218

Merged
RhysSullivan merged 1 commit intors/source-forms-02-auth-sectionfrom
rs/source-forms-03-mcp-forms
Apr 13, 2026
Merged

refactor(mcp): adopt shared primitives in Add/Edit source forms#218
RhysSullivan merged 1 commit intors/source-forms-02-auth-sectionfrom
rs/source-forms-03-mcp-forms

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

3 of 5 — source-forms refactor stack (graphite copy of #189 by @mrzmyr). Stacks on #217.

Replaces the hand-rolled auth/URL/headers UI in the MCP Add/Edit forms with <AuthenticationSection>, wraps the save/cancel row in <FloatActions>, and uses <IOSSpinner> + <Textarea maxRows> for probe status and previews.

The biggest single form in the source-form suite (~820 LOC touched) — isolated so reviewers can focus on it without context-switching between plugins.

See #189 for full discussion.

Stack

  1. feat(react): add UI primitives for source forms #216 feat(react): add UI primitives for source forms
  2. feat(react): add <AuthenticationSection> primitive #217 feat(react): add <AuthenticationSection> primitive
  3. (this PR) refactor(mcp): adopt shared primitives in Add/Edit source forms
  4. refactor(sources): standardize openapi, graphql, google-discovery, onepassword forms
  5. refactor(react): restructure sources list and sources-add container

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 13, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
🔵 In progress
View logs
executor-marketing 56bb182 Commit Preview URL

Branch Preview URL
Apr 13 2026, 07:21 AM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 13, 2026

Open in StackBlitz

@executor/sdk

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/sdk@218

@executor/plugin-file-secrets

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-file-secrets@218

@executor/plugin-google-discovery

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-google-discovery@218

@executor/plugin-graphql

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-graphql@218

@executor/plugin-keychain

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-keychain@218

@executor/plugin-mcp

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-mcp@218

@executor/plugin-onepassword

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-onepassword@218

@executor/plugin-openapi

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-openapi@218

@executor/plugin-workos-vault

npm i https://pkg.pr.new/RhysSullivan/executor/@executor/plugin-workos-vault@218

commit: 56bb182

@RhysSullivan RhysSullivan force-pushed the rs/source-forms-02-auth-section branch from e272cf2 to 260e47a Compare April 13, 2026 06:05
@RhysSullivan RhysSullivan force-pushed the rs/source-forms-03-mcp-forms branch from 20c8935 to 8a99351 Compare April 13, 2026 06:05
@RhysSullivan RhysSullivan force-pushed the rs/source-forms-02-auth-section branch from 260e47a to 63c0d5f Compare April 13, 2026 06:21
@RhysSullivan RhysSullivan force-pushed the rs/source-forms-03-mcp-forms branch from 8a99351 to 029fb14 Compare April 13, 2026 06:21
@RhysSullivan RhysSullivan force-pushed the rs/source-forms-02-auth-section branch from 63c0d5f to 621bbe6 Compare April 13, 2026 07:00
@RhysSullivan RhysSullivan force-pushed the rs/source-forms-03-mcp-forms branch from 029fb14 to 577de1e Compare April 13, 2026 07:00
@RhysSullivan RhysSullivan force-pushed the rs/source-forms-02-auth-section branch from 621bbe6 to b496f10 Compare April 13, 2026 07:05
@RhysSullivan RhysSullivan force-pushed the rs/source-forms-03-mcp-forms branch from 577de1e to 75e2c76 Compare April 13, 2026 07:05
Replaces the hand-rolled auth/URL/headers UI with <FilterTabs> + <HeadersList> + inline OAuth content, <FloatActions> for the save/cancel row, and <IOSSpinner> + <Textarea maxRows> for probe status and previews.
@RhysSullivan RhysSullivan force-pushed the rs/source-forms-02-auth-section branch from b496f10 to 2a5b333 Compare April 13, 2026 07:20
@RhysSullivan RhysSullivan force-pushed the rs/source-forms-03-mcp-forms branch from 75e2c76 to 56bb182 Compare April 13, 2026 07:20
@RhysSullivan RhysSullivan merged commit 77d16f2 into rs/source-forms-02-auth-section Apr 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants