Repository navigation
Conversation
The novel page only renders the latest 30 chapters and data-index-url is empty, so parseNovel now reads data-manifest-url from the chapters container, merges the pack file with live_tail the way the site reader does, and falls back to the page-derived list when the manifest is absent or malformed. This change was authored by an AI coding agent. Co-Authored-By: firstmate-crewmate <crewmate@firstmate.local>
Owner
Author
|
This change now lives in lnreader#2529. It was cherry-picked there unchanged as 99d71f3 (Galaxy Novels 1.1.1 → 1.1.2). lnreader#2529 now closes lnreader#2667 and lnreader#2490. Re-checked against the live site on 2026-10-11. The chapter manifest path still works:
Each list is numbered 1..N with no gaps, and chapter 1 opens. Before the fix each novel showed only the latest 30. lnreader#2529 also adds one follow-up for this plugin: when it falls back to the 30 chapters on the novel page, it now lists them oldest first. Screenshots below are from this repo's plugin playground, run in headless Chromium, not from the LNReader app. This comment was written by an AI coding agent working for the PR author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Fix
Stacks on lnreader#2529 — merge after it. This branch sits on that PR's head, so the diff here is only the chapter-list fix on top. Fixes lnreader#2490.
Galaxy Novels novel pages render only the latest 30 chapters (
data-per-page="30", 30data-chapter-iditems) with an emptydata-index-url, soparseNovelfell through to the page list and returned just the latest 30 — chapters 1–621 of a 651-chapter novel were unreachable.parseNovelnow readsdata-manifest-urlfrom the chapters container and loads the full index the way the site's own reader does: the manifest'spack_urlfile holding every chapter, withlive_tailmerged over the pack by chapter id (newest wins), sorted ascending. When the manifest is absent, unreachable, or malformed it returns null andparseNovelfalls back to the existing HTML list — never an empty list. Only the chapters-container manifest is used; the second manifest on the page covers the VIP time-locked schedule and is ignored, matching the total the site itself renders. Chapter-body and lock handling are untouched. Version1.1.1→1.1.2.Verification (live, 2026-09-24)
check:plugin: 30 chapters before, 651 after; popular (20), search (1), and chapter steps pass. Served counts equal the manifest's own totals in the same run (651/651, 3155/3155, 234/234), numbering contiguous 1..N with no gaps or duplicates; a previously unreachable first chapter returns full text. Fallback proven with manifest requests blocked (30 page-derived chapters, not empty).build:compileandbuild:multisrcpass; eslint clean on the touched file (2 repo-wide errors pre-existing). AI-authored change, no human review.