support memset on 128bit integers#595
Conversation
f2e86c0 to
fbb18af
Compare
There was a problem hiding this comment.
A couple nits - I am already testing a resolution in personal PR: brody2consult#1 - now resolved ✅
I will push the updates to this PR if I do not encounter any failures in brody2consult#1 - now done ✅
e8b869c to
ae65a4c
Compare
ae65a4c to
4afcd1b
Compare
|
I've generalized it to work with arbitrary bitpatterns and on signed and unsigned 128 bit integers. If you could confirm this patch works for you, I'd be happy to merge it. I wrote this into the compiletest:
Generally, we do accept patches that do enable you to use crates that previously didn't compile, even if you can't use the u128bit path. In similar vein, we've added |
This is a quick solution to support the case I described in #594:
This proposal would help me get past the first build issue I have encountered with RustCrypto.
I would love to support non-zero memset fill for both
u128&i128as discussed in #594, but this would involve some more work in testing to hopefully ensure that this is done correctly & not likely broken by potential future refactoring.I would be happy to address any possible feedback on my first contribution to Rust-GPU.
TODO