feat: extend hardware latency reporting to more hosts#1129
Merged
roderickvd merged 6 commits intomasterfrom Mar 20, 2026
Merged
feat: extend hardware latency reporting to more hosts#1129roderickvd merged 6 commits intomasterfrom
roderickvd merged 6 commits intomasterfrom
Conversation
This was referenced Mar 17, 2026
roderickvd
force-pushed
the
fix/hardware-latency
branch
3 times, most recently
from
793001c to
81c71de
Compare
Member
Author
|
I see some ❤️ - please test and report back! Your test runs are much appreciated. |
roderickvd
force-pushed
the
fix/hardware-latency
branch
from
22fbfd2 to
9bc5015
Compare
roderickvd
changed the title
Member
Author
|
No feedback and this looks good code-wise after a few iterations, so I'm going to merge it and hopefully give it a little more exposure. Please open an issue if you find any. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
playback - callbackunderreports host latency on several hosts because the hardware pipeline delay isn't included.This PR fixes it using each host's native API:
kAudioDevicePropertyLatency + kAudioDevicePropertySafetyOffsetGetStreamLatency()(hardware latency beyond the buffer)ASIOGetLatencies()(hardware latency beyond the buffer)CycleTimes::next_usecsdirectly instead of estimating fromcurrent_usecs + buffer_durationAudioContext.baseLatency + outputLatencySupersedes #964
Fixes #773