Repository navigation
orbit: draw album art from the shell's saved cover - #209
Merged
Merged
Conversation
Orbit fed the player's web art URL straight into an Image, which makes Qt load its TLS stack inside the shell and can crash Quickshell (quickshell#1368). The shell already saves the cover to disk.
Member
Author
🦊 mika's reviewNo actionable findings. Mika looked for bugs, security issues, and risks in the diff and came up empty on clear defects.
🦊 Generated by Mika — the Ryoku org's self-hosted AI code reviewer. Machine findings: verify before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orbit fed the player's web art URL straight into an Image, so Qt loaded its TLS stack inside the shell; with Quickshell 0.3.2 on Qt 6.12 that can crash the shell (quickshell#1368, reported in Ryoku-dev/ryoku#768). The shell already saves the cover to disk, so Orbit now draws Music.artUrl like Ryoku's own bars. Version 1.0.2.