Repository navigation
fix(DM01-6386): change github_pull_request_id column type to bigint - #653
Merged
Merged
Conversation
GitHub PR IDs are global integers that have grown beyond PostgreSQL's INTEGER limit (2,147,483,647), causing NumericValueOutOfRange errors when inserting new pull_request records from GitHub webhook events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub webhook events are failing with:
in
infrabox-githubpod when processing pull request events.Root Cause
pull_request.github_pull_request_idis defined asINTEGER(32-bit, max 2,147,483,647) in 00001.sql:262. GitHub PR IDs are global integers that have grown beyond this limit, causing the insert in trigger.py:352 to overflow.Fix
Migration
00049.sqlalters the column toBIGINT(64-bit).Jira
https://jira.tools.sap/browse/DM01-6386