Repository navigation
fix: sync sdk with orchestration spec - #189
Conversation
mwien
left a comment
There was a problem hiding this comment.
Thanks for the PR. A few things need to be clarified (and maybe should be moved to separate tickets/PR):
- how we support file content, especially concerning the convenience layer (see this ADR from the JS team)
- how to support special request headers (here specifically for
AI-Object-Store-Secret-Name) and if that header needs to be exposed to users at all
Another question: should we add integration tests for some of the features?
…"drop_unsupported_params": True
|
In general, some more integration tests are added and the embedding multiform functionality is removed for now since the specific cohere model is not supported and planned from orchestration side. |
yamaceay
left a comment
There was a problem hiding this comment.
overall lgtm, just small comments / questions from my side
…empty partial orchestration header and headers serialization
alpkom
left a comment
There was a problem hiding this comment.
Looks good to me overall. I also see that the decisions from the meeting are applied.
And I've had a look at Marcel's review, as it was requested, and it looks like all matters have been addressed.
Alperen has reviewed and approved. Merging this to unblock the CI pipeline.
Context
Closes SAP/ai-sdk-python-backlog#58.
What this PR does and why it is needed
AI-Object-Store-Secret-Nameheader currently)Definition of Done