Skip to content

feat: Add granite guardian filter - #200

Merged
OscarDDD merged 13 commits into
mainfrom
Add_Granite_Guardian_Filter
Nov 5, 2026
Merged

OscarDDD merged 13 commits into
mainfrom
Add_Granite_Guardian_Filter

Conversation

@OscarDDD

@OscarDDD OscarDDD commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Context

Closes SAP/ai-sdk-python-backlog#56.

What this PR does and why it is needed

This PR adds IBM Granite Guardian 4.1 as a new self-hosted content filter provider for the content filtering module, alongside the existing Azure Content Safety and Llama Guard 3 providers. Unit tests, integration tests are also included.

Definition of Done

  • Code is tested (Unit, Integration, E2E)
  • Error handling created / updated & covered by the tests above
  • Documentation updated
    • Only Public APIs are allowed to be used in documentation/tutorials/sample code
  • (Optional) Aligned changes with the JS/TS and Java SDK
  • (Optional) Release notes updated -->

@OscarDDD OscarDDD self-assigned this Oct 21, 2026
@OscarDDD
OscarDDD marked this pull request as ready for review October 21, 2026 15:29

@mwien mwien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have tests with enable_reasoning = True especially in integration/e2e tests or sample code?

Apart from that just small nitpicks (see below).

@OscarDDD
OscarDDD requested a review from mwien October 30, 2026 08:33

@yamaceay yamaceay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is in place, just small comments

@yamaceay yamaceay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OscarDDD

OscarDDD commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Do you have tests with enable_reasoning = True especially in integration/e2e tests or sample code?

Apart from that just small nitpicks (see below).

Yes, tests with enable_reasoning = True are also added.

@alpkom alpkom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall.
And I've had a look at Marcel's review, as it was requested, and it looks like all matters have been addressed.

@OscarDDD
OscarDDD merged commit 1bad6c8 into main Nov 5, 2026
14 checks passed
@OscarDDD
OscarDDD deleted the Add_Granite_Guardian_Filter branch November 5, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants