Open
Conversation
Flag is set to false by default. Cross checked setting of flag at user creation from Admin Console > User Management > Create User, then the corresponding record in mongo db, which does indeed have the flag.
added to Admin Console > User Management > User row > Edit action > Dialog box > checkbox and also to PUT /user API and also (partially) to User details (this is currently erroring)
If null is passed to email subscription flag, nothing will be changed. Previously, it was the case that null could not be passed, behaviorally the same value as before would have to be reapplied in expected use cases which could cause data consistency issues
toggle blocking and loading indicator are remaining. then connecting the backend is expected
1. updateUserProperties: if null dont update that specific property. this behavior now applies to each updatabale property in the security service method. 2. checkbox tile onToggle async loading view is now triggered with callbacks instead of expecting onToggle to use blocking asynchrony
Progress indicator position fixed: checkbox tile was using GSS of SuggestedMultiSelection before. This enforced rigid CSS with the !important flag necessary for its more complex functionality that was making logic for overlay stack unnecessarily complex. The necessary styling was thus extracted out into CheckboxTile.gss Toast notifications not showing above footer fixed: this was due to z index of footer being 1000 and that of Notification being 100. I brought up notification.css z-index to 1001.
Accomplished by adding user flag as a dimension in HasUserContext
migration method added which adds flag value = false for DID_OPT_OUT_OF_FEATURE_AND_COMMUNITY_EMAILS in method that ran before the failing test
The following commit was not checked properly. It was assumed to be a merge with the main branch, but was actually a merge with a very stale main branch with many conflicts that were then resolved manually. 1373405
The changes were not supposed to be added. They were an artifact of my specific Mac development environment
these were artifacts from my personal Mac dev environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed by this PR
Bug 6187
Description
A didOptOutOfFeatureAndCommunityEmails flag was added to the User document/object.
A checkbox was added in User Preferences > Favorites/Notifications to allow users to set its value.
The flag's representation was added to Data Mining to allow admins to get users emails filtered by this.
A migration method was added to set this flag. The default value is false. It sets them right after the users are read from the database into the java domain.
A hyperlink to http://127.0.0.1:8888/gwt/Home.html#/user/profile/preferences/: can be added to the content of relevant emails in the footer.
Checklist for Pull Requests
bugXXXX