Skip to content

fix: fix a11y issue with reading selected address#21209

Merged
uroslates merged 18 commits intodevelopfrom
feature/CXSPA-12107-checkout-address-a11y
Mar 26, 2026
Merged

fix: fix a11y issue with reading selected address#21209
uroslates merged 18 commits intodevelopfrom
feature/CXSPA-12107-checkout-address-a11y

Conversation

@uroslates
Copy link
Copy Markdown
Contributor

Closes: https://jira.tools.sap/browse/CXSPA-12107.

QA: Start the app and use JAWS to verify that upon adding any product to the cart and Proceeding to the checkout any selected address is read out completely (previously only 'Selected Address' was read out by the screen reader).

@uroslates uroslates requested a review from a team as a code owner March 3, 2026 11:17
@github-actions github-actions Bot marked this pull request as draft March 3, 2026 11:19
@uroslates uroslates marked this pull request as ready for review March 3, 2026 14:21
@cypress
Copy link
Copy Markdown

cypress Bot commented Mar 3, 2026

spartacus    Run #52476

Run Properties:  status check passed Passed #52476  •  git commit 178959064e ℹ️: Merge 0909405637449876edc1ea0b37d29258ffd732e9 into 8ff383fa2bb73c83864b78ff1953...
Project spartacus
Branch Review feature/CXSPA-12107-checkout-address-a11y
Run status status check passed Passed #52476
Run duration 04m 19s
Commit git commit 178959064e ℹ️: Merge 0909405637449876edc1ea0b37d29258ffd732e9 into 8ff383fa2bb73c83864b78ff1953...
Committer Uros Lates
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 101
View all changes introduced in this branch ↗︎

@github-actions github-actions Bot marked this pull request as draft March 16, 2026 15:18
@uroslates uroslates marked this pull request as ready for review March 17, 2026 11:32
@StanislavSukhanov StanislavSukhanov self-assigned this Mar 19, 2026
@StanislavSukhanov StanislavSukhanov self-requested a review March 19, 2026 12:54
@github-actions github-actions Bot marked this pull request as draft March 19, 2026 14:10
@uroslates uroslates marked this pull request as ready for review March 19, 2026 15:26
Copy link
Copy Markdown
Contributor

@StanislavSukhanov StanislavSukhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit 👍

@uroslates uroslates marked this pull request as ready for review March 20, 2026 17:30
@github-actions
Copy link
Copy Markdown
Contributor

E2E Tests Failed ❌

📸 Download Screenshots


Commit: e2d88f04ccc2c970fdcf6335a4fd8fe71536f646

@github-actions
Copy link
Copy Markdown
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft March 20, 2026 19:49
@uroslates uroslates marked this pull request as ready for review March 21, 2026 09:39
@github-actions github-actions Bot marked this pull request as draft March 23, 2026 10:28
@uroslates uroslates marked this pull request as ready for review March 23, 2026 10:30
@github-actions github-actions Bot marked this pull request as draft March 24, 2026 10:02
@uroslates uroslates marked this pull request as ready for review March 24, 2026 10:02
@github-actions
Copy link
Copy Markdown
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft March 24, 2026 10:16
@uroslates uroslates marked this pull request as ready for review March 24, 2026 10:16
@github-actions github-actions Bot marked this pull request as draft March 24, 2026 13:47
@uroslates uroslates marked this pull request as ready for review March 24, 2026 14:37
@github-actions github-actions Bot marked this pull request as draft March 24, 2026 14:37
@uroslates uroslates marked this pull request as ready for review March 24, 2026 14:39
@github-actions
Copy link
Copy Markdown
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft March 25, 2026 11:22
@uroslates uroslates marked this pull request as ready for review March 25, 2026 13:03
@github-actions github-actions Bot marked this pull request as draft March 26, 2026 08:43
@StanislavSukhanov StanislavSukhanov marked this pull request as ready for review March 26, 2026 09:56
@uroslates uroslates merged commit aec865b into develop Mar 26, 2026
38 checks passed
@uroslates uroslates deleted the feature/CXSPA-12107-checkout-address-a11y branch March 26, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants