Repository navigation
Allow configuring additional annotations on the generated workload - #91
Closed
martin-briatka wants to merge 1 commit into
Closed
martin-briatka wants to merge 1 commit into
martin-briatka wants to merge 1 commit into
Conversation
martin-briatka
marked this pull request as draft
November 9, 2026 12:11
martin-briatka
changed the title
Add a spec.annotations (map[string]string) field. The operator renders its entries into the generated workload's commonAnnotations, so users can attach arbitrary annotations to the workload metadata. The field is empty by default, so existing deployments are unaffected.
martin-briatka
force-pushed
the
fix/tls-cert-rotation-reloader
branch
from
November 9, 2026 12:44
d359909 to
5607460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
spec.annotations(map[string]string) field. The operator renders its entries into the generated workload'scommonAnnotations, so users can attach arbitrary annotations to the workload metadata.The field is empty by default, so existing deployments are unaffected.
Changes
api/v1alpha1/types.go—Annotations map[string]stringonValkeySpecpkg/operator/data/parameters.yaml— render.annotationsintocommonAnnotationsapi/v1alpha1/zz_generated.deepcopy.go+crds/cache.cs.sap.com_valkeys.yaml— regenerated viamake manifests generateTesting
go buildandgo vetclean.