Repository navigation
Allow configuring additional annotations on the generated workload - #92
Draft
martin-briatka wants to merge 1 commit into
Draft
martin-briatka wants to merge 1 commit into
martin-briatka wants to merge 1 commit into
Conversation
martin-briatka
force-pushed
the
feat/workload-annotations
branch
2 times, most recently
from
November 9, 2026 13:32
30b2b84 to
03c8dcf
Compare
Add a spec.annotations (map[string]string) field. The operator merges its entries onto the metadata of every generated StatefulSet. The merge is done in the operator rather than in the chart templates, so it is independent of the vendored chart. The field is empty by default, so existing deployments are unaffected.
martin-briatka
force-pushed
the
feat/workload-annotations
branch
from
November 9, 2026 13:47
03c8dcf to
a430f76
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
spec.annotations(map[string]string) field. The operator merges its entries onto the metadata of every generated StatefulSet (primary, replica and sentinel), so users can attach arbitrary annotations to the workload.The merge is performed in the operator (a generator wrapper), not in the chart templates, so it is independent of the vendored chart — the same way
TopologySpreadConstraintsare already injected today. The field is empty by default, so existing deployments are unaffected.Changes
api/v1alpha1/types.go—Annotations map[string]stringonValkeySpecinternal/transformer/annotation_generator.go— generator wrapper that readsspec.annotationsand merges them onto every generated StatefulSet's metadatapkg/operator/operator.go— wrap the resource generator with the annotation generatorapi/v1alpha1/zz_generated.deepcopy.go+crds/cache.cs.sap.com_valkeys.yaml— regenerated viamake manifests generateTesting
go buildandgo vetclean.