[Production] Light yield detvar for gen2

[linyan-w]

Description

This is a PR for gen2 lightyield detvar (2 PDE changes).
This is intended for gen2 production.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{blue}\bf{\textrm{IMPORTANT UPDATE Feb 2nd 2026:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production for gen 2 SBND analyses, you must make two PRs: one for develop and one for the production/sbnd-gen2 branch.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees
• Linked any relevant issues under Developement
• Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
• Does this affect the standard workflow?
• Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
No

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
To be added (Mar 26th)

[linyan-w]

Uhhhhh the high Eff one needs to scrub to G4 and modify the ScintPreScale. Working on it.

[linyan-w]

It still doesn't fix the highEff issue, but the lowEff one works, and is probably worth merging to get 1 PDS detvar going.

[nathanielerowe]

trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_04

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[linyan-w]

So... I think this works fine for the highEff ones. Let's keep as is and merge. If anything we can fix in the future.

[nathanielerowe]

@linyan-w Ok, it looks like this will cause issues based on all of the CI issues. If you still want to merge, I will default to what you want since it is a production branch, but be careful as it may cause problems down the line.

[nathanielerowe]

For documentation purposes, here is the fcl level issue:

36:   what():  ---- Parse error BEGIN
37:   Local lookup error
38:   ---- Can't find key BEGIN
39:     sbnd_reco1_producer_sequenceVar (at part "sbnd_reco1_producer_sequenceVar")
40:   ---- Can't find key END
41:   at line 31, character 25, of file "/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/build_slf7.x86_64/sbndcode/fcl/reco1_detvar_sbnd.fcl"
42:   
43:   physics.reco1:          @local::sbnd_reco1_producer_sequenceVar
44:                           ^
45: ---- Parse error END```

[nathanielerowe]

The TVector3 issues were coming from blips. Those can be ignored. It seems like it ran fine, but just has issues with comparisons due to the change in data types.