Import RT and BH fixes from romeel_dev#72
Conversation
add magma2 hydro option
Add KIARA cooling and chemistry
Add Kiara stars and star_formation routines. Compiles but doesn't work
Add Kiara feedback and Obsidian BH model; full KIARA model now works
Update recoupling and cooling changes from romeel_dev
Matthieu compile fixes & code formatting
…nto romeel_dev
|
Merge in recent changes from SWIFT/Master as well as small changes from romeel_dev |
romeeld
left a comment
There was a problem hiding this comment.
Large merge requires review. Seems OK since I'm just updating to romeel_dev which is a tested branch.
|
Hi @romeeld Thanks very much for contributing all your modules back into the shared public base. That is very much appreciated. Given the amount of code here, I propose to merge things piece-by-piece so as to (try to) not break the rest. |
|
Hi Matthieu,
Thanks, there’s really no hurry with this. I am still working on some small things but it would be good to start making a plan to import all the KIARA stuff.
Maybe it’s best to delay this for now. This was really just to get it on your radar at some point.
Cheers,
romeel
=====================================================
Prof. Romeel Davé, Chair of Physics
Institute for Astronomy, Royal Observatory, Edinburgh EH9 3HJ
http://www.roe.ac.uk/ifa/people/rad.html
=====================================================
… On 20 Mar 2026, at 08:48, Matthieu Schaller ***@***.***> wrote:
MatthieuSchaller
left a comment
(SWIFTSIM/SWIFT#72)
<#72 (comment)>
Hi @romeeld <https://github.com/romeeld>
Thanks very much for contributing all your modules back into the shared public base. That is very much appreciated.
Given the amount of code here, I propose to merge things piece-by-piece so as to (try to) not break the rest.
Maybe the easiest is for me to do this module-by-module (e.g. take the cooling then stars..) and make it work with the rest of the code base. I'd expect that this way, we import the changes required in the "not subgrid" part of the code also more naturally.
—
Reply to this email directly, view it on GitHub <#72?email_source=notifications&email_token=AFPBQD5DULF5QITHPVFLWXD4RUAVBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMBZGY3DIMBYGQZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4096640842>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFPBQDYCLCHIUWTE3TCU7U34RUAVBAVCNFSM6AAAAACWUWE3W6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAOJWGY2DAOBUGI>.
You are receiving this because you were mentioned.
|
|
Sounds good. |
No description provided.