Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AEADChunkWriter.WritetakeswriteAccessbefore it writes the length chunk, the payload and the padding. It unlocks only after all three writes succeed. If one of them fails,Writereturns with the lock still held, and the nextWriteon the same writer blocks forever.This change releases the lock with
defer, the same fix that 9b95ab8 applied toStreamChunkWriter.Write.A regression test makes the first write fail through an upstream writer that always returns an error. It then checks that a second write returns an error instead of blocking. Before this change, the second write blocks and the test fails after two seconds.