Repository navigation
fix(sessions): allow Windows snapshot publication and cleanup - #552
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows session scans can fail to publish snapshots or retire cache directories because cc-switch still holds lock-file handles inside the directory being renamed.
Release those child handles while retaining the existing parent scope/root lock through the rename. This keeps active builders and readers protected and preserves atomic pointer publication. The change covers publishing, generation collection, and CLI/query namespace retirement; it does not change session scanning, parsing, or cache formats.
Extend the existing reader-lifetime test to check eventual generation retirement, add query-startup coverage for live versus abandoned namespaces, and run the full paged-manifest suite in the existing Windows CI job.
Validation:
cargo fmt --checkandgit diff --checkpassed.cargo clippy --lib --no-default-featurescompleted with existing warnings outside the changed lines.Closes #542