Repository navigation
Conversation
Correctness - Orchestrator takes PASS/FAIL/SKIP from each script's JSON result; non-zero exit, missing result, or timeout (kills whole process group) is FAIL - Report no longer fabricates memory; latency is per-batch p50/p99 with CV noise flag; throughput = batch / mean latency - Precision labels match what ran: fp32 disables TF32 (matmul + cuDNN), tf32 opt-in, bf16 is real bf16, training reports amp_fp16/amp_bf16 - Compute ops: correct FLOP/byte accounting, calibrated reps for small kernels, DRAM-sized tensors, GEMM checked against fp64 reference - Training measures GPU optimizer steps on a device-resident batch - LLM: fixed prompt/output lengths, separate TTFT, prefill and decode tok/s, perplexity check; Ollama warmup + no prompt-cache hits; llama.cpp via llama-bench JSON - ComfyUI: real device memory, workflow errors fail, server log drained - No silent fallbacks (YOLO ResNet placeholder, insecure ONNX download, ORT provider fallback now SKIP) Workloads: YOLO11, Qwen3/Llama-3.1, SD3.5, FLUX.2-klein, Z-Image-Turbo; generic torchvision classification/training; unified gpu_ops script. Reporting: run JSON/CSV/Markdown + history.jsonl, direction-aware compare.py with regression exit code, rebuilt dashboard. Tests: pytest suite (harness math, accounting, status rules, reports, frontends) + GPU smoke tests; CI runs them plus a CPU end-to-end run. Validated on RTX 4090: 48/48 default matrix PASS. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review and overhaul of ML-Bench. The JSON result block each script prints now decides PASS/FAIL. Every number is labelled with the precision that actually ran and backed by a correctness check. Models and reporting are updated, and there is now a test suite.
Correctness fixes
avg_latency_mswas really 1/throughput. Reports now show per-batch p50/p99 latency and flag noisy runs (CV > 10%).fp32turns TF32 off for both matmul and cuDNN.tf32is now an explicit opt-in.bf16runs real bf16.amp_fp16/amp_bf16.llama-bench -o json.Workloads
Reporting
history.jsonl.compare.pyhandles metrics where lower is better and exits non-zero on regressions, so CI can use it.Tests
Validation (RTX 4090)
🤖 Generated with Claude Code