Skip to content

ci(deploy): add --prod flag to vercel-args on main push - #455

Merged
SamuelIVX merged 2 commits into
mainfrom
fix/vercel-production-deploy
Nov 9, 2026
Merged

SamuelIVX merged 2 commits into
mainfrom
fix/vercel-production-deploy

Conversation

@SamuelIVX

Copy link
Copy Markdown
Owner

Summary

Updates .github/workflows/deploy.yml to include vercel-args: ${{ github.event_name == 'push' && '--prod' || '' }}.

  • Problem: Without --prod, amondnet/vercel-action defaults to preview deployments even when triggered by pushes/merges to main. This resulted in changes being deployed to ephemeral preview URLs rather than updating the production domain (https://paycorehq.vercel.app/).
  • Solution: Pass --prod when github.event_name == 'push', ensuring all merges to main deploy directly to production while pull requests continue generating preview deployments.

Ensure merges and pushes to main deploy directly to production on
Vercel rather than generating preview deployments.

Co-authored-by: Codex <noreply@openai.com>
@vercel

vercel Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
paycore Ready Ready Preview Nov 9, 2026 12:07am UTC

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1849b2dd-b520-4299-8cb7-5fe24ed77dd8
Commits

Reviewing files that changed from the base of the PR and between 94ef6b3 and bf51e1a.

Files selected for processing: 1

  • .github/workflows/deploy.yml
Summary

Summary by CodeRabbit

  • Chores
    • Deployment behavior now distinguishes push events from other events: pushes deploy to production, while other events run without the production flag. This may affect which version is publicly available after a deployment; no changes to application features or user-facing functionality are included.

The deploy workflow passes --prod to Vercel for push events. For other event types, it passes an empty string.

Changes: Deploy workflow

Layer / File(s) Summary
Select Vercel arguments
.github/workflows/deploy.yml
The deploy step passes --prod for push events and an empty string for other event types.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Low · previous review e1b87

Pushes to main will now deploy to production as intended, and pull requests still get previews. Rerunning an older main workflow run would now redeploy that older commit to production. This needs only owner awareness, not a blocking fix.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title names the change: adding a --prod flag to vercel-args for pushes to main in the Vercel deploy workflow. This matches the single file change in .github/workflows/deploy.yml, which sets vercel…
Description check Passed The description states the change: it adds vercel-args with --prod when github.event_name is push. It gives the problem (amondnet/vercel-action defaults to preview deployments on pushes to main) and t…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: adding a --prod flag to vercel-args for pushes to main in the Vercel deploy workflow. This matches the single file change in .github/workflows/deploy.yml, which sets vercel-args to --prod for push events and to an empty string otherwise. The title uses the conventional commit prefix 'ci(deploy):', which fits a CI workflow change.

Full details: Description check

Explanation

The description states the change: it adds vercel-args with --prod when github.event_name is push. It gives the problem (amondnet/vercel-action defaults to preview deployments on pushes to main) and the solution (production deploys for pushes, previews for pull requests). This matches the workflow change in the raw summary.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

.github/workflows/deploy.yml-32-32: 1

32-32: Major · Functional Correctness · Heavy lift

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Reject stale production reruns.

If someone reruns an older main push after a newer deployment, checkout uses the older SHA and this condition deploys it to production. That can roll back the live site. (docs.github.com)

Check the SHA against the current main head before deploying. Also ensure a stale rerun cannot cancel a newer deployment through the existing concurrency group.

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 31a94f3b-636d-4db3-ba19-f2f44aded569
Commits

Reviewing files that changed from the base of the PR and between 94ef6b3 and e1b8707.

Files selected for processing: 1

  • .github/workflows/deploy.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Review details

Context from checks skipped due to timeout: 8

  • GitHub Check: CodeQL
  • GitHub Check: CodeRabbit
  • GitHub Check: Lint Code Base
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Diff Coverage
  • GitHub Check: Build
  • GitHub Check: Analyze (actions)
  • GitHub Check: Deploy

Align concurrency cancellation with repo standards by only canceling
in-progress runs for pull requests. Add a pre-deployment check on push
events to verify the commit SHA matches the remote main HEAD before
deploying to production, preventing stale workflow reruns from rolling
back the live site.

Co-authored-by: Codex <noreply@openai.com>
@SamuelIVX
SamuelIVX merged commit e0e149d into main Nov 9, 2026
18 checks passed
@SamuelIVX
SamuelIVX deleted the fix/vercel-production-deploy branch November 9, 2026 00:09

This branch was successfully deployed

1 active deployment
Preview — bf51e1ab Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant