Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 95.32% 90.69% -4.64%
==========================================
Files 86 86
Lines 9372 9433 +61
==========================================
- Hits 8934 8555 -379
- Misses 438 878 +440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
My laptop froze as well if compiled with multiple threads because it ran out of the 8GB memory. @EmilyBourne Would be nice if that can be improved. |
|
Over the last few weeks I probably had like 20 freezes with VS Code taking up to 10 minutes to finally crash 😂 |
😆 This is always a danger with templating. I don't think we instantiate any more instances of the classes than you did before though so I'm not sure why this is so bad for you. Maybe try compiling with less parallelism? |
|
With 2 VS instances running, only one threaded compilation works and with a single VS Code instance I can use 2 threads (before your new PR. Maybe now its better) |
Remove the
SourceTermsuperclass. There are many types ofSourceTerm. Managing this via astd::variantin theConfigParsercauses the linker to overuse resources (this lead to freezes on my local laptop). To avoid this problem asolvemethod is added to theConfigParserwhich callsGMGPolar.solvewith local instances of the necessary boundary conditions and source term. Closes #131Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):