Skip to content

Remove stdvector polar grid#212

Draft
AbdelhadiKara wants to merge 10 commits intomainfrom
akara_remove_stdvector_PolarGrid
Draft

Remove stdvector polar grid#212
AbdelhadiKara wants to merge 10 commits intomainfrom
akara_remove_stdvector_PolarGrid

Conversation

@AbdelhadiKara
Copy link
Copy Markdown
Collaborator

@AbdelhadiKara AbdelhadiKara commented Apr 8, 2026

Remove std::vector in PolarGrid class

To avoid inheritance issues when porting the code to GPU, we need to remove std::vector containers since it is not gpu compliant.

See the issue #208 for more details

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@AbdelhadiKara AbdelhadiKara changed the title Akara remove stdvector polar grid Remove stdvector polar grid Apr 8, 2026
@julianlitz
Copy link
Copy Markdown
Collaborator

Amazing work so far ☺️

@AbdelhadiKara
Copy link
Copy Markdown
Collaborator Author

Amazing work so far ☺️

Thank you

@AbdelhadiKara AbdelhadiKara marked this pull request as ready for review April 9, 2026 06:59
@AbdelhadiKara AbdelhadiKara marked this pull request as draft April 9, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants