Skip to content

1522 Improve DynamicNPI structure through harmonization across models and more options#1523

Open
mknaranja wants to merge 20 commits intomainfrom
1522-improve-dynamicnpis-structure
Open

1522 Improve DynamicNPI structure through harmonization across models and more options#1523
mknaranja wants to merge 20 commits intomainfrom
1522-improve-dynamicnpis-structure

Conversation

@mknaranja
Copy link
Copy Markdown
Member

@mknaranja mknaranja commented Mar 29, 2026

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • The performance-oriented variable 'interval' got removed as this does not substantially improve performance and might lead to unexpected outcomes
  • (!) The removal of this parameter might change simulation results (to the better...)
  • Parameters of directive beginning and end (see Improve end_dynamic_npis parameter #315) moved from Model to DynamicNPI
  • Parameter DynamicNPIImplementationDelay moved from Model to DynamicNPI
  • (!) Switched order of DynamicNPI check and advance function which might lead to minimal deviations

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
  • New code adheres to coding guidelines.
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP).
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code.
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added.
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed.
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease).
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #315 #1522

@mknaranja mknaranja linked an issue Mar 29, 2026 that may be closed by this pull request
2 tasks
@mknaranja
Copy link
Copy Markdown
Member Author

mknaranja commented Mar 29, 2026

What currently remains to be done:

  • fully adapt to new structure that NPI directive end is now NPI and not model parameter
    • check e.g. benchmark flow_simulation_ode_secirvvs.cpp to set delay to 7
  • stop integrator with NPI ends
  • check backward compatibility
  • write detailed tests

@mknaranja mknaranja marked this pull request as ready for review March 30, 2026 21:56
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (a0c1752) to head (f6b5751).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
+ Coverage   97.37%   97.41%   +0.04%     
==========================================
  Files         188      188              
  Lines       16619    16647      +28     
==========================================
+ Hits        16182    16216      +34     
+ Misses        437      431       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve DynamicNPIs structure Improve end_dynamic_npis parameter

2 participants