Skip to content

feat(code-index): index authenticated Git submodules - #4801

Merged
ScriptedAlchemy merged 92 commits into
masterfrom
fix/4593-skipped-nested-repository-audit
Nov 14, 2026
Merged

ScriptedAlchemy merged 92 commits into
masterfrom
fix/4593-skipped-nested-repository-audit

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

Refs #4593.

Enable direct Git submodules through the default-off project setting index.include_submodules.v1, followed by a daemon restart. The parent-relative child paths participate in source walking, grep, structural search, unmounted-file audit, and graph indexing. Parent-to-child call edges remain in one graph.

Source authority

  • Live admission binds the staged parent gitlink and exact pin, staged and working .gitmodules, and child checkout to the parent-owned Git module store.
  • Child commits, local additions, edits, and removals participate in freshness. Retained readers and snapshot capture revalidate the bound authority; unreadable parent Git state is an error, not an empty result.
  • Historical capture uses the selected parent tree's registration and pinned child commit in the local parent-owned module store. Missing historical authority is unavailable, never substituted with live bytes.
  • Linked child worktrees, unrelated nested clones, deeper gitlinks, uninitialized children, and parent aliases into child repositories remain excluded. Ordinary tracked aliases within the parent remain supported.

Repairs and verification

The earlier blanket DRAFT / HOLD MERGE wording is superseded by the maintainer's request to finish and verify this PR. The prerequisite dashboard fixes and scheduler progress work are integrated. The PR is ready for review; this does not authorize bypassing required checks.

Earlier locally verified commit: 6ca67c5b3669d72a60a1e6dd1379e765e355f6a2.

  • Fixed strict Clippy failures in the Unix binding witness and post-read binding check, without lint suppression or policy changes; corrected tree-capture guard formatting.
  • Strengthened the split-index corruption regression to require refusal from retained graph and lazy-walk readers, not merely a changed metadata witness.
  • Added a real-Git capture regression: revoke the staged gitlink after capture starts, refuse the snapshot, preserve the prior publication, restore authorization, and successfully publish the edited child.
  • Native macOS complete indexing suites passed on the patch before the final behavior-preserving nested-if collapse: 398 source-index tests and 714 runtime tests, with two existing opt-in tests ignored.
  • Final patch: both crate Bazel rustfmt checks and strict Clippy unit targets passed. All 6 focused runtime submodule tests reran successfully with the anti-vacuity helper after the final edit. The 19 focused source-index tests passed earlier on the same source-index test code.

Current head and hosted validation

The current head 76da516e integrates actual master aa5b722a, including the beta-103 metadata and reviewed release-runner recovery. Its tree is 48bcaa1350a7f5f571e4c3f9d956554c281f043d. It also includes the reviewed failure-only snapshot assertion context: if the existing materialization assertion fails, the fixture reports the already-collected scan-budget evidence. No scan, clock, deadline, transaction, or success oracle changes.

Independent full-tree review verified the release integration and the subsequent disjoint runner-recovery integration. The complete submodule/source-boundary policy, revision-23 canonical golden, all 4,211 Rust source postimages, and lockfile remain unchanged from the reviewed pre-runner integration. Actual commit-message validation and diff checks passed. All preceding ordinary and native Windows jobs were terminal, and their complete logs were preserved before this non-force update.

Ordinary CI run 43637394154 passed Linux 180/180 targets, with 60 fresh executions, on synthetic checkout 41323489, whose tree exactly matches this PR head. The canonical source-index suite passed freshly; the index unit and runtime unit results were cached. The ordinary Windows job 132585189472 also passed 467 build/typecheck targets and 26,371 actions; its complete log is preserved and independently hash-verified. All 14 ordinary workflow jobs are terminal with success or configured skip conclusions. Native workflow 43637859699, dispatched once on the actual PR branch at exact 76da516e, is now complete and successful. Its Linux job passed 180/180 targets, 37 fresh. Its native Windows job 132587107941 passed all three complete owning targets through the normal Bazel cache: 0/3 executed freshly. Cached results report index unit 391/391, canonical index suite 227/227, and runtime 628 passed with two pre-existing ignored cases. These are current-head cached qualifications, not fresh native executions. The complete Linux and native Windows logs are preserved and independently hash-verified.

Previous head d3327bf0

The previous head d3327bf0 integrates actual master d2650cdd, after the repository owner merged #4827. Its tree is 99f2b1805b52ea794e976865ccf0fa9bdb25c5a7. Independent review verified the complete merge: all 57 PR paths and 32 incoming master paths retain their exact respective contents, modes, and types. The paths do not overlap, and no manual resolution was required.

The actual retained-baseline update includes the incoming database batch-execution and retention changes. All PR-specific submodule, source-boundary, fixture, TypeScript, and private-filesystem repairs remain unchanged. Pinned formatting, actual commit-message validation, and diff checks passed. All jobs on the prior head were terminal, and both complete Windows logs were saved and independently verified before this update. Ordinary CI run 43623216974 completed Linux with 177/180 targets passed, 88 fresh executions. Automation has two retained-publication wait failures; global database exceeded its existing 300-second bound after 448 of 548 reported case completions; the retained OpenCode snapshot fixture produced zero materialized records where one was required. The count does not identify an individually stalled database case. Daemon-service separately passed all 443 cases freshly.

The native workflow's Linux job completed 176/180 targets, 89 fresh executions. Its automation, sessions, and global-database owning logs are byte-identical to the ordinary run, so those are one observation, not independent reproductions. It additionally failed the provider descendant-pipe deadline assertion at 10.692 seconds; that same case passed in the fresh ordinary job. Code-index-runtime passed 714 cases with two pre-existing ignored cases freshly. The index unit and canonical round-trip suite passes in this run were cached.

Complete terminal Linux logs and artifacts are preserved. Bounded source review has not established a cause for the publication waits, snapshot failure, database timeout, or descendant-pipe delay. The current head now includes the independently reviewed failure-only snapshot assertion context described above; this does not establish a causal repair for the historical snapshot failure. The exact-head native Windows job 132547384675 passed all three complete targets freshly: source-index unit 391/391 in 26.62 seconds, canonical source-index suite 227/227 in 17.95 seconds, and code-index-runtime 628 passed with two pre-existing ignored cases in 176.04 seconds. The canonical round-trip case explicitly passed. Its complete 608,916-byte log was saved and independently verified. The ordinary Windows job 132548180704 also passed: 467 targets and 26,371 actions. Its complete 586,089-byte log was saved and independently verified. All jobs in both workflows are now terminal; ordinary Windows remains build/typecheck evidence, separate from the native execution above. The manual workflow remains failed because of its Linux result.

Separate measurement run 43631589275 at 53f788da completed with 179/180 targets passed, 108 fresh executions. Automation, daemon, sessions, runtime acceptance, global database, MCP, and composition all passed freshly. The snapshot case passed without failure-only scan-budget output. The sole failing target was the hooks/LSP suite (26/29 cases): two receipt-drain waits and the final linked-worktree publication condition. The observed elapsed timings do not establish a cause for the earlier publication, process, database, or snapshot failures. Complete logs and artifacts were preserved, then the temporary retained-publication and process tracing was removed by exact inverse 82a4410d, restoring the entire reviewed premeasurement tree. Only the permanent failure-only snapshot assertion context is included in this PR; no temporary capture remains.

Verified results on prior head b77eb943

The authentic revision-23 manifest golden correction executed successfully. In manual run 43617768798, Linux's complete source-index suite passed 227/227 freshly, including the canonical digest and every subsequent segment-roster, census, and round-trip assertion; source-index unit tests passed 402/402 freshly. The prior expected digest was corrected only to the encoder output actually observed on parent 342f9040: sha256:b8669b6269e0a571d9f6fa58fb9f9f7e254fe47c03c1dc231a7d71623abcfac5.

The exact-head native Windows job 132523404460 passed all three complete targets freshly: source-index unit 391/391, canonical source-index suite 227/227, and code-index-runtime 628 passed with two pre-existing ignored. The complete 601,061-byte log was saved and independently verified. This satisfies the native requirement for historical head b77eb943; the integrated current head requires its own qualification.

The manual workflow's Linux job finished 179/180 targets, 57 fresh executions. Its only failure was the dense-reference rename fixture's initial-publication deadline, before the rename preview assertions ran. Its final status was failure despite the passing native Windows job.

Ordinary run 43618532983 finished Linux at 179/180 targets, 21 fresh executions. Runtime acceptance passed 141 of 142 cases; the remaining LSP journey timed out awaiting acknowledgement 10000. The MCP suite separately passed 682/682 freshly. Bounded source and trace review did not establish a causal repair for these timing failures. Workloads, deadlines, retry policy, and assertions remain unchanged.

The ordinary Windows job 132524492543 passed build/typecheck for all 467 targets, with 26,371 actions. Its complete 552,379-byte log was saved and independently verified. This ordinary job does not execute native Windows tests.

Earlier repairs retained

At e04035c0, Clippy and Linux/Windows compilation identified the same graph context-path caller mismatch: sealed_source_bytes required a canonical LiveSourceBoundaries owner. The reviewed caller repair keeps the actual policy and that owner within the existing blocking worker across sealed reads, preserving source-digest checks, cancellation, deadlines, and refusal handling. Parent 342f9040 compiled and reached the owning suites. The global-database timeout on that parent remains a historical failed run; no causal repair is inferred from later successful controls.

The temporary dashboard subscriber, fixture invocations, and fact-add timing spans remain removed. The earlier full passing run at 34e92220 and its complete Windows receipt were preserved before subsequent source updates.

Remaining merge checks

Required hosted CI and explicitly dispatched native Windows indexing suites must pass on the latest head. The native target set is the source-index unit suite, the canonical code_index_suite owning the digest/round-trip oracle, and the code-index-runtime unit suite. The Windows runtime suite includes child-HEAD/add/delete transition, historical pinned graph, and restart journeys. New actionable review findings must be addressed before merge.

The current-head native qualification, run 43637859699 at exact 76da516efdcd7e487ae268f5ff13e5598ef0aa39, completed successfully with all three full Windows targets resolved from the normal Bazel cache. The ordinary workflow has also completed successfully; final review and merge checks still apply. The d332 and b77 fresh native executions above remain historical. Any later source correction requires qualification of the resulting final head. The prior b77 filter-only diagnostic objects remain unreferenced; no temporary diagnostic capture is included in this PR.

No approval, merge, or completion of #4593 is claimed by these local results.

Keep parent repository source admission unchanged; use one shared
walker for exclusion evidence instead of a second filesystem scan.

Refs #4593
@changeset-bot

changeset-bot Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 76da516

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy marked this pull request as draft November 8, 2026 01:11

Copy link
Copy Markdown
Owner Author

Refs #4593 — validation blocker at exact head 38bc131598d5d993295f97b7001811209a1b16a5.

The repository-gates job failed before Rust execution: https://github.com/ScriptedAlchemy/tracedecay/actions/runs/42433144833/job/128586224987 . The actual failures are:

  1. check-generated-rust-entrypoints: stale generated entrypoint/toolchain contract; its diagnostic names package.json packageManager/engines and the setup-pnpm node-version instruction surface.
  2. check-generated-api: unexpected generated AgentPromotionStatus.swift and AgentSignalGate.swift bridge surfaces.
  3. Domain ownership contract drift: docs/generated/domain-module-map.json, docs/generated/runtime-service-map.json, and crates/tracedecay-configuration/src/generated/project_settings_contract.rs.

git diff --check, CI-shape/scope/environment-policy checks and Bazel BUILD graph checks passed. This is NOT a rustfmt failure, and none of those passes establishes Rust compilation or behavioral correctness. Native tests were skipped by draft selection. I could not establish whether these gate failures also occur on current master: the master status/workflow requests were unavailable to this integration. Do not label them pre-existing without that comparison.

No source fix, Rust test execution, independent review, branch update, merge or issue closure was completed in this follow-up. This environment has no executable repository checkout or Bazel; direct repository retrieval failed, and no usable remote execution/workflow-dispatch capability was exposed. This is a validation limitation, not evidence that the implementation is correct.

#4801 remains diagnostic-only and draft. It does not yet satisfy authenticated submodule admission, pinned child-tree capture, child-aware freshness, or consistent retrieval/graph behavior. Retain Refs #4593; do not infer issue completion from a green diagnostic PR. Reuse this existing issue PR rather than opening a duplicate. The next implementation must use one authenticated submodule inventory across admission/capture/freshness/retrieval, invalidate parent reuse for child commits and edits, preserve linked-worktree/untrusted-repository exclusions, and add nonzero Bazel regressions including opt-in/off, spoof rejection, child changes, historical capture and restart behavior.

Coordination: the dedicated #4593 owner remains responsible for implementation; PR maintenance owns CI assistance without racing its branch. Do not repair unrelated decision-model generated paths by importing forbidden work. #4776 and all Kev/decision-model work remain draft and unmergeable by instruction; #4763 remains read-only. No protections or tests were weakened.

Copy link
Copy Markdown
Owner Author

Refs #4593 — exact-head CI repair 1f8c1997090e4631ee38f50a32af4186e8153c12 (nonforce fast-forward from 38bc131): applied the three exact Rust formatting replacements reported by hosted Bazel //crates/tracedecay-code-index:rustfmt_check_2024 in run 42433144833. Correction: my earlier comment erroneously attributed the failure to generated entrypoints/API/domain maps. The repository-gates log shows the actual failure was rustfmt_check_2024 only; 8 other Bazel test targets passed. No generated-source edits are warranted by that log. Fresh run 42437677389 was queued when last checked; no claim it passed.

The PR is still partial: it adds skipped-nested-repository diagnostics and regression source, but NOT authenticated submodule indexing, freshness, or indexed retrieval. HOLD MERGE even if its current-head diagnostics tests pass: keep this same PR open to complete #4593. Being reviewable or passing preliminary tests does not mean the issue's acceptance is met. No complete-implementation, native macOS or independent-review proof exists. Keep Refs #4593, issue open, and protected Kev/release PRs untouched.

Limit skipped-repository samples during traversal, honor directory policy
before collecting diagnostics, and quote bounded path labels. Propagate
source-walk failures instead of returning an empty successful audit.

Add behavioral coverage for bounded sampling, policy scope, preserved
ecosystem caveats, Unicode/control-character paths, and missing roots.

Refs #4593

Copy link
Copy Markdown
Owner Author

Refs #4593 — published source repair 8d6f07e1bb326630a313e1911d8bd271f337dd6c on this same branch with expected_sha=1f8c1997090e4631ee38f50a32af4186e8153c12, force=false; independently re-read PR head confirms the update.

Fixed unbounded skipped-repository collection, diagnostics escaping configured directory exclusions, unquoted/unbounded path labels, and swallowed filesystem-walk failures. Added six behavioral regression cases (one Unix-only filename case); existing initialized-submodule and linked/nested-repository exclusions are preserved. Only source_walk.rs, unmounted_files.rs, and the new nested-repository test module changed; no scheduler, generated contract, release, infrastructure or model changes.

Current-head CI: https://github.com/ScriptedAlchemy/tracedecay/actions/runs/42442123433 — queued when inspected. These Rust regressions have NOT executed; author diff review is NOT independent review. The prior successful draft run skipped Rust/Clippy/native jobs, so it is not acceptance evidence for these changes.

The existing merge hold remains. This repairs the current audit implementation, not the still-unimplemented optional authenticated submodule indexing feature. Keep the PR draft/open and #4593 open. Continue the integrated admission/capture/freshness/retrieval implementation here rather than opening a duplicate or treating more diagnostic fixes as feature completion.

Apply the exact formatter changes reported by the hosted Bazel
rustfmt_check_2024 failure on PR #4801.

Refs #4593

Copy link
Copy Markdown
Owner Author

Refs #4593 — published nonforce, expected-head fast-forward 8d6f07e → 1b49877, fixing the precise three rustfmt_check_2024 hunks from the current-head hosted Bazel repository-gates failure in run 42442123433 (job 128613365191). The exact diff changes only formatting in source_walk/nested_repository_tests.rs; 8 other repository-gate targets passed before the format failure. Verified #4801 now points to 1b49877, and current-head run 42447730459 was queued at last read. These behavioral Rust regressions have still not run; native/Linux/Clippy remained skipped on the draft workflow, and there is no submitted independent review. HOLD MERGE. Authenticated submodule indexing in parent capture, freshness, historical Git-tree capture, policy/configuration, and indexed/live retrieval remains unimplemented; keep PR draft, issue open and existing hourly owner enabled. Do not import protected Kev/release branches or change CI protections.

Use one source boundary for interactive walks, Git candidate classification,
worktree capture (including ignored-file admissions), and freshness. Parent
tracked files hidden by a new nested .git marker become tombstones, invalidate
clean HEAD-tree reuse, and return when the marker disappears. Reject source
paths passing through symlinked directories or lexical escapes.

Add real Git classification and filesystem regressions for nested directory,
gitdir-file, symlink, path traversal and removal behavior.

Refs #4593

Copy link
Copy Markdown
Owner Author

Refs #4593 — published source repair 624cc833 on the existing branch, expected-head NONFORCE fast-forward from 1b498778. Four source paths changed: shared nested-repository/symlink/escape guard in source_walk, parent Git classification tombstones + dirty/freshness invalidation for tracked paths newly hidden behind nested .git, worktree capture guard including explicit ignored-source admission, and freshness roster parity. New real Git and source-boundary regression source is committed; it has not executed via Bazel. The exact-head CI run 42449422792 was still pending; native/OS Rust jobs are skipped for draft PRs. No independent review. This is a partial fail-closed security/correctness fix, NOT the registered-submodule opt-in feature. Hold #4801 DRAFT/unmerged and #4593 OPEN; next owner work must deliver canonical config + authenticated 160000/.gitmodules/topology inventory, child-aware capture, historical pinning, freshness/retrieval parity and nonzero Bazel/native acceptance. PR maintenance: assist only with exact-head CI and do not race this source branch. Preserve #4800/#4508 scheduler work, Kev/#4776 DRAFT and release #4763 read-only.

Apply four exact replacements from hosted Bazel rustfmt_check_2024
at PR #4801 head 624cc83; no behavioral source change.

Refs #4593

Copy link
Copy Markdown
Owner Author

Refs #4593 — published exact-head CI repair 9beb7b8 to the existing DRAFT #4801, using expected head 624cc8338a1cfe8486b0638ba88fbbae0df9fa33 and force=false. Hosted run 42449422792 failed Bazel rustfmt_check_2024 for exactly four formatting hunks (two in source_walk.rs, two in classification.rs); eight unrelated repository tests passed. This patch makes exactly those four formatting replacements in those two files, with no behavior changes. PR/ref readback confirms the new head. Fresh current-head run 42455645684 was QUEUED at inspection; no pass is claimed. The draft workflow skips Linux/Windows/macOS Rust tests and Clippy; zero new behavioral Rust tests have executed, and no independent review exists. HOLD MERGE: the integrated authenticated submodule feature (canonical default-off setting, gitlink + .gitmodules + child topology, dirty/historical child capture, freshness, graph/live parity, toggles and restarts) remains unimplemented. Keep issue OPEN and owner schedule unchanged. No Kev/#4776, release/#4763, or peer PR changes.

Sample .git marker evidence for tracked and explicitly admitted source
ancestors even when Git dirwalk never recurses into tracked-only folders.
Test marker creation and removal against a real Git parent index.

Refs #4593
Directory metadata changes when the marker is removed, so the original
cached roster must not be treated as restored merely by marker absence.

Refs #4593
A registered gitlink remains an untrusted nested source boundary even if
its child .git marker is absent. Keep live grep and audit in default-deny
parity with the parent index; include/glob cannot lift repository trust.

Exercise a real registered Git submodule with its marker removed.
Refs #4593

Copy link
Copy Markdown
Owner Author

Refs #4593 — published narrow default-deny source fix 704a9aac135046fe1d720242a482561a61eb5274 to #4801 with an expected-head NONFORCE fast-forward from 0119cf9 (remote PR ref verified). Parent 160000 gitlinks now remain excluded by the shared live source walker even if the child .git marker is removed; the real registered-submodule regression fixture now exercises that missing-marker case and explicit glob refusal. Production uses the existing in-process gix opener (no shell Git or network); no child indexing is enabled. Source diff changes one file only: crates/tracedecay-code-index/src/source_walk.rs.

Current-head run: https://github.com/ScriptedAlchemy/tracedecay/actions/runs/42466514013 (queued at check). NO Bazel behavioral Rust pass or independent review claim. Do not merge or mark ready. Feature acceptance remains integrated authenticated opt-in, pinned historical child capture, child status/freshness and cross-boundary graph/index/live retrieval, with nonzero Bazel/native validation. Preserve #4800 and protected Kev/release lanes.

Apply the two exact rustfmt_check_2024 hunks from hosted run 42466514013.
No source behavior changes; authenticated submodule indexing remains pending.

Refs #4593

Copy link
Copy Markdown
Owner Author

Refs #4593 — narrow hosted Bazel formatting repair published at 1899d261 by nonforce, expected-head fast-forward from 704a9aac, independently verified against the remote Git ref and PR head.

Exact-head run 42466514013, repository-gates job 128687191524, failed only //crates/tracedecay-code-index:rustfmt_check_2024, with two exact hunks in source_walk.rs (line wrapping around the workdir and index reads). The other 8 repository-gate targets passed, most cached; these were not code-index behavioral Rust regressions. Commit 1899d261 applies only those two reported formatting replacements in one file, no behavior changes. New-head CI and nonzero Bazel Rust test evidence have not yet been established.

HOLD MERGE: this PR remains DRAFT and contains only exclusion/diagnostic/freshness hardening. The requested default-off authenticated submodule inventory, selected historical child-tree capture, dirty child freshness, and graph/indexed/live retrieval parity remain unimplemented. No independent review. #4593 stays open. Please do not merge or change the draft selection to conceal missing behavior, and preserve #4800/#4508, protected #4776 Kev and read-only #4763.

Copy link
Copy Markdown
Owner Author

Refs #4593 — new source-review boundary mismatch, regression needed; not a claimed exploit or passing test (reviewed at exact head 1899d261c9c6486f572a0cbdf619d07315b65378).

The default-deny live walker now checks parent stage-0 gitlink roots through source_walk.rs::parent_gitlink_paths, including when the child's .git marker is absent. But code_index_scheduler/reconcile.rs::capture_admitted_candidate (around 3977–3983) and freshness_witness.rs::source_candidates (around 135–143) still validate explicitly admitted ignored paths using only source_walk::has_nested_repository_ancestor. That helper checks nested .git markers and symlink/path ancestry, not parent-index gitlink roots. Therefore the new deny boundary is not yet shared by these capture/freshness paths.

Test the concrete scenario with a real parent 160000 gitlink under node_modules/<package>, a registered .gitmodules entry, child source still present but its .git marker missing, and an ignored-dependency admission/retained roster. The admission must fail closed or retire before child bytes enter a parent generation, even when the package path matches .gitignore. Check ignored_dependencies.rs::prove_gix_ignored (exact-path lookup plus ignore match) against gitlink ancestor semantics rather than assuming it already prevents this. Also assert live grep/AST and freshness parity across marker removal and restart. This is an actionable trust-boundary test requirement, not evidence that the runtime admission exploit has reproduced: no nonzero Bazel Rust test can be executed in this environment.

Current-head hosted workflow 42468887836 has passed repository gates, but Rust native/OS tests and Clippy were skipped for this draft; the Dashboard job remained queued when checked. Do not push a speculative fix that cancels that run. Fix via the one canonical authenticated submodule boundary, not a third independent scanner, and keep DRAFT/HOLD MERGE, Refs #4593, and issue open until full integrated acceptance.

A parent stage-0 gitlink remains tracked repository source even when its
child checkout loses the .git marker. Check every indexed ancestor before
an ignored dependency is admitted or revalidated, preserving the existing
proof for ordinary ignored sources.

Add a real local Git submodule regression that removes the child marker
and checks both the admission proof and production source-read refusal.

Refs #4593

Copy link
Copy Markdown
Owner Author

Refs #4593 — published 77332ede0f9b9cb557bd41185203eba9500c3f0a by expected-head, NONFORCE fast-forward from 1899d261 on this existing draft PR.

The ignored-dependency gix proof now checks every parent index ancestor for mode-160000 gitlinks, not only the exact candidate path. This closes the omitted-marker admission path discussed in comment 6720823044 for verified ignored dependencies, including the production source read and existing ignored-roster revalidation. Added a real local Git submodule regression source: verified stage-0 gitlink and .gitmodules, removed the child .git marker, asserted typed refusal by proof and read, plus a normal ignored-source control. Only ignored_dependencies.rs changed; candidate diff and live remote head were read back.

No Rust regression has executed through Bazel, and there is no independent review. Current-head hosted CI 42482445184 was queued. Previous-head run 42468887836 completed successfully after re-running a Dashboard job blocked by a transient download timeout; draft native Rust/Clippy remained skipped. I independently checked the disposable Git fixture commands locally, but that is not a repository Rust test or acceptance evidence.

HOLD MERGE / keep DRAFT / #4593 OPEN. The default-off authenticated submodule inventory, selected child-commit historical capture, child-aware freshness, and indexed/graph/live retrieval parity remain undone. Protected Kev/release PRs, #4800/#4508, and CI protections were not changed.

Refs #4593. Full authenticated child indexing still incomplete.

Copy link
Copy Markdown
Owner Author

Refs #4593 — guarded source repair on existing DRAFT #4801, HOLD MERGE.

Commit 2b230e8232f6ffd23675223c261fcfbd0a26e80a addresses a concrete remaining default-deny gap: a child checkout with its .git marker removed and its parent gitlink staged for removal disappears from the index but remains a mode-160000 gitlink in the parent's HEAD tree. The interactive source walker previously checked only index gitlinks and the current marker, so an explicit include/glob could admit those live child bytes. It now unions parent index gitlinks with parent HEAD-tree gitlinks, handles unborn HEAD, and fails closed on unreadable committed-tree authority. The existing real-Git submodule test now commits the parent, stages removal without deleting the child, verifies index absence plus HEAD's 160000 entry, and checks ordinary and explicitly scoped walks still exclude the child. A real Git fixture was independently probed for these Git semantics; that is not a repository Rust/Bazel test.

One file changed: crates/tracedecay-code-index/src/source_walk.rs. Published via expected-head 77332ede nonforce fast-forward, verified by direct branch and PR REST reads. Exact-head hosted CI run 42499856015 was queued on last check. No nonzero Bazel Rust regression pass, native OS test, or independent code review is claimed. Draft workflow selection skips native Rust/Clippy.

The integrated canonical default-off authenticated submodule opt-in, shared inventory across child candidate capture/freshness, pinned historical submodule trees, and parent-relative graph/retrieval are not implemented. Do not mark ready, merge, or close #4593. Protected #4776 Kev, #4763 release and #4800/#4508 peers untouched.

Refs #4593. Reuse the parent's index-plus-HEAD boundary for ignored
sources and cover the real staged-removal checkout scenario.

The authenticated opt-in indexing feature remains incomplete.

Copy link
Copy Markdown
Owner Author

Refs #4593 — source repair published on existing DRAFT PR; HOLD MERGE.

Commit f925fe65 is a guarded, nonforce fast-forward from 2b230e8232f6ffd23675223c261fcfbd0a26e80a. It corrects another default-denial discrepancy: the ignored-dependency proof used only the staged parent index. After staging removal of a registered gitlink and removing the child's .git marker, live search still denies the child through the parent HEAD but explicitly admitted ignored-source reads could treat the same child files as ordinary ignored dependencies.

Ignored-source proof now calls the same index-plus-HEAD parent gitlink boundary as the source walker. The real-Git fixture commits a parent with a 160000 submodule, stages removal with git rm --cached, verifies the index no longer has that gitlink while HEAD still does, and asserts ignored admission and source-read refusal; its ordinary ignored-source control remains. Exactly two changed files: source_walk.rs (exports the existing boundary) and ignored_dependencies.rs (uses it and adds the regression).

Verification limit: read back the exact commit and diff; no nonzero Bazel Rust test executed locally. Current-head hosted run 42503394287 was queued and chooses native=none because the PR is draft, so it cannot establish Rust behavior. No independent review. This remains a partial fail-closed repair only; canonical default-off authenticated submodule inventory, child capture/freshness, pinned historical-tree capture, graph/indexed/live parity, and acceptance tests are outstanding. Keep Refs #4593, PR DRAFT/unmerged, issue open. Preserve scheduler #4800/#4508 and protected Kev/release PRs.

devin-ai-integration[bot]

This comment was marked as resolved.

@ScriptedAlchemy
ScriptedAlchemy merged commit 97caca9 into master Nov 14, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant