Repository navigation
fix(sessions): retain the cause of cold Git sync failures - #4841
Conversation
Reject empty project selectors and budget the entire finding, including both commands, deletion warning and measured overage. Omit actions that cannot fit intact. Add filesystem-backed malformed/long-selector regressions and sparse 15 GiB reporting coverage with a canonical identity and long Unicode root. Preserve concurrent formatting commit d7c2d3a. Native Bazel validation remains required; no Cargo commands or CI changes. Refs #4616
Repair three hosted automation_runner_test failures by supplying the configured executable identity required by the production prefilter. Use the same identity for the prefilter and retained runner, preserving manual-schedule, exact-ledger, live-lock and lock-race assertions. Add a production-prefilter regression for unconfigured refusal, deduplication and same-occurrence recovery after binding, with zero backend calls and no effectful terminal. Do not relax backend admission, change timeouts, or alter the graph publication changes. Refs #4532
(cherry picked from commit 621940d)
|
…sort-reclaim fix(doctor): name last-resort reclaim for overbound project stores
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Merge-blocking per-issue scope review (current head 2c0c24050593): The PR describes cold Git-sync error provenance in the session runtime + CLI fixture, but master...head still changes crates/tracedecay-maintenance/src/retention/footprint.rs with the separate destructive projects forget Doctor guidance and its tests. The #4799 Doctor PR was marked merged at c1d1c90123fa, into the codex/cold-git-sync-diagnostics prerequisite, not into master; current master b9d9df58cc35 lacks registered_project_reclaim_hint and the Doctor warning. Accordingly this is not a landed #4616 acceptance slice. Please keep the issue-specific Doctor change in its focused landing lane and the cold Git diagnostic in this separate review lane. Do not merge the three-file combined diff as though it were just the two-file cold-sync fixture; preserve all existing peer history, reconcile the intended target/base without a forced rewrite, and revalidate nonzero Bazel behavior and every live caller after the separation. The older full-green run does not certify a new reconciled head.
This preserves the independent session diagnostic change from Doctor PR #4799. Cold Git sync records the failing operation and its cause through the existing diagnostic path when scope resolution, scope storage or the topology publisher fails. The real CLI fixture includes daemon output on failure and retains its mounted-project and JSON assertions.
Commit
872c5f8a31carries the original two files from621940d19e. Its base is masterbe2e1349c6. The hosted Linux suite for the original combined commit passed 183 targets. The native macOS Bazel cold-daemon CLI journey executed and passed in 10.17s. The full exact-head Linux run is pending. Keep this prerequisite draft for independent review. Original Linux run