Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
52bac32
fix(code-graph): isolate sealed proof repair on master
ScriptedAlchemy Nov 9, 2026
3630dc9
Merge master into fix/4507-sealed-proof-master
ScriptedAlchemy Nov 9, 2026
6546e18
Merge master into fix/4507-sealed-proof-master
ScriptedAlchemy Nov 9, 2026
1274238
chore(code-graph): merge master into sealed-proof review branch
ScriptedAlchemy Nov 9, 2026
43e8458
fix(code-graph): preserve unchanged sealed-proof snapshots
ScriptedAlchemy Nov 9, 2026
e7c420e
fix(code-graph): bound retained sealed proofs across roots
ScriptedAlchemy Nov 10, 2026
bbe4fe2
fix(code-graph): pin active sealed proofs during root eviction
ScriptedAlchemy Nov 10, 2026
85c8cd0
fix(code-graph): preserve new proofs while old roots are pinned
ScriptedAlchemy Nov 10, 2026
a6bbbbb
fix(bench): include source mutation in one-file edit measurements
ScriptedAlchemy Nov 10, 2026
e4064bb
fix(bench): fence one-file measurements to the pre-edit generation
ScriptedAlchemy Nov 10, 2026
232d53a
fix(benchmark): fence edits to regular clone-owned files
ScriptedAlchemy Nov 10, 2026
7540e8c
fix(benchmark): parse canonical structured status for readiness
ScriptedAlchemy Nov 10, 2026
ec0d6a4
fix(benchmark): prove semantic one-file edits reached ready graph
ScriptedAlchemy Nov 10, 2026
ad8ebaa
fix(benchmark): fence one-file latency to the served graph
ScriptedAlchemy Nov 10, 2026
4b72024
perf(code-index): expose sealed source proof work per edit
ScriptedAlchemy Nov 10, 2026
feeb11e
test(bench): initialize edit telemetry fixtures
ScriptedAlchemy Nov 11, 2026
d2abc3b
fix(bench): sample macOS daemon RSS during incremental edits
ScriptedAlchemy Nov 11, 2026
b8b917a
test(bench): load module before macOS RSS assertions
ScriptedAlchemy Nov 11, 2026
1dd8f6e
fix(bench): terminate orphaned daemon process groups
ScriptedAlchemy Nov 11, 2026
89eff34
fix(bench): preserve Python source file modes
ScriptedAlchemy Nov 11, 2026
6661541
Merge remote-tracking branch 'origin/master' into fix/4507-sealed-pro…
ScriptedAlchemy Nov 11, 2026
8272693
chore(graph): integrate proof and progress fixes from master
ScriptedAlchemy Nov 11, 2026
87c151d
Merge branch 'master' into fix/4507-sealed-proof-master
ScriptedAlchemy Nov 11, 2026
57b09ac
fix(bench): keep harness test within its Bazel size
ScriptedAlchemy Nov 11, 2026
e4d5929
test(lsp): capture daemon timings on acknowledgement failure
ScriptedAlchemy Nov 12, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 40 additions & 33 deletions crates/tracedecay-application/src/feedback/concrete.rs
Original file line number Diff line number Diff line change
Expand Up @@ -268,29 +268,34 @@ impl ProjectFeedbackObservationSinkV1 {
})
}

#[tracing::instrument(name = "usecases.feedback.close_drain", level = "trace", skip_all)]
async fn close_and_drain(&self) -> Result<(), FeedbackRuntimeError> {
let terminal = {
let _admission = self
.admission
.lock()
.unwrap_or_else(std::sync::PoisonError::into_inner);
if self.closed.load(Ordering::Acquire) {
None
} else {
let terminal = self.prepare_terminal_envelope()?;
self.closed.store(true, Ordering::Release);
Some(terminal)
fn close_and_drain(
self: &Arc<Self>,
) -> impl Future<Output = Result<(), FeedbackRuntimeError>> + Send + 'static + use<> {
let terminal = self.close_admission();
let sink = Arc::clone(self);
async move {
terminal?;
sink.join_worker().await
}
}

fn close_admission(&self) -> Result<(), FeedbackRuntimeError> {
let _admission = self
.admission
.lock()
.unwrap_or_else(std::sync::PoisonError::into_inner);
if !self.closed.load(Ordering::Acquire) {
let terminal = self.prepare_terminal_envelope()?;
self.closed.store(true, Ordering::Release);
if self.control_sender.try_send(terminal).is_err() {
self.record_shutdown_failure(&FeedbackRuntimeError::ObservationWorker);
}
};
let terminal_outcome = if let Some(terminal) = terminal {
self.control_sender
.try_send(terminal)
.map_err(|_| FeedbackRuntimeError::ObservationWorker)
} else {
Ok(())
};
}
Ok(())
}

#[tracing::instrument(name = "usecases.feedback.close_drain", level = "trace", skip_all)]
async fn join_worker(&self) -> Result<(), FeedbackRuntimeError> {
let mut worker = self.worker.lock().await;
let outcome = match worker.as_ref() {
Some(task) => match task.wait().await {
Expand All @@ -303,7 +308,6 @@ impl ProjectFeedbackObservationSinkV1 {
None => Ok(()),
};
worker.take();
let outcome = terminal_outcome.and(outcome);
if let Err(error) = &outcome {
self.record_shutdown_failure(error);
}
Expand Down Expand Up @@ -525,10 +529,12 @@ impl FeedbackRuntime {
})
}

/// Stop observation admission, persist the producer's terminal record, and
/// join the worker that owns the project database before store retirement.
pub async fn close_and_drain_observations(&self) -> Result<(), FeedbackRuntimeError> {
self.observation_sink.close_and_drain().await
/// Close admission immediately and return a join for the terminal write
/// and worker that owns the project database.
pub fn close_and_drain_observations(
&self,
) -> impl Future<Output = Result<(), FeedbackRuntimeError>> + Send + 'static + use<> {
self.observation_sink.close_and_drain()
}

pub fn owner(&self) -> Arc<ConcreteFeedbackOwner> {
Expand Down Expand Up @@ -2471,11 +2477,12 @@ mod tests {
let boot_id = sink.boot_id.clone();

let worker_guard = sink.worker.lock().await;
let closing_sink = Arc::clone(&sink);
let close = tokio::spawn(async move { closing_sink.close_and_drain().await });
while !sink.closed.load(Ordering::Acquire) {
tokio::task::yield_now().await;
}
let drain = sink.close_and_drain();
assert!(
sink.closed.load(Ordering::Acquire),
"admission closes before joining the worker"
);
let close = tokio::spawn(drain);
close.abort();
assert!(close.await.unwrap_err().is_cancelled());
drop(worker_guard);
Expand Down Expand Up @@ -2515,7 +2522,7 @@ mod tests {
Err(())
})
.unwrap();
let sink = ProjectFeedbackObservationSinkV1 {
let sink = Arc::new(ProjectFeedbackObservationSinkV1 {
sender,
control_sender,
boot_id: canonical_sha256(&"feedback-terminal-failure").unwrap(),
Expand All @@ -2525,7 +2532,7 @@ mod tests {
closed: AtomicBool::new(false),
shutdown_failure: AtomicU8::new(OBSERVATION_SHUTDOWN_CLEAN),
worker: AsyncMutex::new(Some(worker)),
};
});

assert!(matches!(
sink.close_and_drain().await,
Expand Down
25 changes: 18 additions & 7 deletions crates/tracedecay-daemon-service/src/project_runtime/shutdown.rs
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,9 @@ impl ProjectRuntimeRegistryV1 {
/// Shut every project runtime down and leave the registry empty.
///
/// Routers become unavailable before feedback owners drop and Work
/// providers are joined. The drain is single-flight, so the first
/// caller's `deadline` bounds the producer drains for every caller.
/// providers are joined. The first caller supplies the observability flush
/// deadline for the shared task. The daemon bounds its own wait separately,
/// and the registry retains the task until its database workers finish.
#[tracing::instrument(
name = "daemon.service.project_runtime.shutdown",
level = "trace",
Expand Down Expand Up @@ -368,12 +369,22 @@ async fn shut_down_advisory(runtimes: &BTreeMap<PathBuf, ProjectRuntime>) -> Vec
}

async fn shut_down_feedback(runtimes: &BTreeMap<PathBuf, ProjectRuntime>) -> Vec<String> {
// Start every project's terminal write before joining its independent
// database worker. The retained drain keeps ownership of each store
// through its terminal write, even if the daemon stops waiting.
let drains: Vec<_> = runtimes
.iter()
.filter_map(|(project_root, runtime)| {
let feedback = runtime.feedback.as_ref()?;
Some((
project_root,
feedback.runtime().close_and_drain_observations(),
))
})
.collect();
let mut lost_work = Vec::new();
for (project_root, runtime) in runtimes {
let Some(feedback) = runtime.feedback.as_ref() else {
continue;
};
if let Err(error) = feedback.runtime().close_and_drain_observations().await {
for (project_root, drain) in drains {
if let Err(error) = drain.await {
lost_work.push(format!(
"{}: feedback observations: {error}",
project_root.display()
Expand Down
Loading
Loading