Skip to content

test(daemon): compare status within one paused attempt - #4891

Merged
ScriptedAlchemy merged 1 commit into
masterfrom
fix/paused-cold-attempt-observation
Nov 14, 2026
Merged

ScriptedAlchemy merged 1 commit into
masterfrom
fix/paused-cold-attempt-observation

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fix the cold-preseal crash-recovery fixture so its observational-status assertion compares the same paused producer attempt.

Motivation

The fixture's .entered file is a persistent arrival receipt. It survives cancellation of the attempt that created it. Initial admission can still deliver a queued reconcile after the graph mounts, advancing the source epoch and replacing that attempt.

The failed daemon-suite run on #4863 compared attempt 1 in parse_evidence with attempt 2 in capture. The existing fixture interpreted that owner replacement as a status-polling mutation. This patch establishes the intended same-owner precondition; it does not attribute every scheduling delay to that path.

Changes

  • Wait for a positive, fully completed parse_evidence progress boundary while the producer hold is armed.
  • Take both status observations inside the existing 45-second precondition deadline. If daemon, producer, or attempt identity changes, acquire a new paused baseline within that same deadline.
  • Keep full equality for observations of the same attempt, so any same-owner progress mutation still fails immediately.
  • Preserve the 25 ms polling cadence, positive progress and timestamp assertions, hard process kill, cold restart, and verified native-graph recovery checks.

Test plan

  • Passed the exact pinned Rust 1.100.0 formatter on the changed file with empty output.
  • Passed commitlint and git diff --check.
  • Independently reviewed the queued-reconcile, cancellation, and marker lifetimes, plus the complete fixture diff.
  • Hosted //crates/tracedecay:daemon_suite must execute the affected regression. No local Rust/Bazel test pass is claimed.

This is a single-file fixture correction based on current master; the active #4863 Windows run and feature branch are unchanged.


Devin Review

@changeset-bot

changeset-bot Bot commented Nov 14, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1972ce0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@ScriptedAlchemy
ScriptedAlchemy merged commit a9b00ea into master Nov 14, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant