Repository navigation
feat(proximity): retire constant-score threshold controls - #4909
Merged
Merged
Conversation
Upgrade impact: a project configuration that holds feedback.proximity.risk_threshold now returns configuration ResetRequired. Reset the project configuration and re-apply custom settings; feedback.proximity.relationship_hints.v1 controls neighborhood hints.
Restore the live-activation assertion the retired threshold used to carry: a no-restart setting commits and reports drift current in the daemon runtime. Seed the released key-set fixture through BLOB-typed production rows, restore the immutability triggers the delete steps around, and bump the registry schema revision for the replaced definition.
The reset fixture is the released revision-9 key set, so it is named for that registry revision and carries no capture prose. Seeding reads each affected table's trigger name and definition from sqlite_master, drops those exact identifiers with quoted names, and restores the captured SQL, so the ten immutability triggers have one authority. The second reset test now seeds the legacy numeric entry beside the current relationship-hint entry and asserts typed ResetRequired, so the retired key is refused on its own rather than through a missing key. Evidence: global-db unit_test 550 passed; configuration unit_test 41 passed; application unit_test 610 passed; tracedecay unit_test 821 passed; runtime_acceptance_suite 142 passed after one LSP capability flake; exact runs 5/5, 1/1, 5/5, 2/2 with nonzero counts.
|
ScriptedAlchemy
enabled auto-merge
November 16, 2026 20:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Relationship warnings should follow one live policy link rather than a constant numerical risk threshold.
What changed
Retire the numeric
feedback.proximity.risk_thresholdsetting: its key, pin, bounds check, and read mapping are gone. Addfeedback.proximity.relationship_hints.v1, a boolean project setting that defaults totrueand carries aProximityPolicyPinV1snapshot of the configuration revision and behavior digest. The registry definition revision moves to 10.An old snapshot that still holds the numeric key now returns the typed
ResetRequiredstate, and a setter for the retired key is refused as an unknown setting. The reset test seeds a real revision-9 registry capture, including the exact typed BLOB and the captured and restoredsqlite_mastertriggers.The direct read runtime keeps its canonical source, enum outcomes, typed denials, and stale and coverage conditions. There is no constant fallback. Live relationship-hint activation is current with no restart. The sync cooldown setting stays
pending_restart.Refs #4416.
Scope
No legacy mapper, no additive default, no cross-lane config edits, and no hand edits to generated files. The L5 configuration phase waits for this merge. No production browser-only gate is missing from this task.
Tradeoffs
Old numeric snapshots reset under the existing typed authority, per the approved no-compatibility and no-migration rule. The policy setting replaces the numeric one. This is not a transparent default preservation. No metrics are claimed.
Blast Radius
Advisory evaluation, the policy-setting registry, and their direct consumers. One new dashboard test only. No SDK package source and no runtime compatibility shim.
Verification
Rerun on base
80ebe1bf65b5708f44a4b4d6df0148cefe024284after rebase:bazel test //crates/tracedecay-global-db:unit_test --test_filter=configuration::store::tests::retired_proximity_threshold: 2 passed, 0 failed, 548 filtered out.bazel test //crates/tracedecay:unit_test --test_filter=mcp::tools::handlers::configuration_batch_behavior_tests: 2 passed, 0 failed, 819 filtered out. Covers the no-restart live activation journey.bazel test //crates/tracedecay:runtime_acceptance_suite --test_filter=advisory_runtime_acceptance::one_saved_edit_cycle_returns_all_four_advisory_pillars_together: 1 passed, 0 failed, 141 filtered out.bazel buildofrustfmt_check_2024for tracedecay-application, tracedecay-configuration, tracedecay-contracts, tracedecay-domain, tracedecay-global-db, and tracedecay: 6 targets build.pnpm run contracts:check: contracts up to date.pnpm vitest run src/viz/proximity/ProximityPanel.dom.test.tsx: 1 passed.commitlinton all 4 commits: exit 0.The remote LSP null case stays unresolved and is not waived as an environment bloom failure. Local acceptance passed.