Repository navigation
test(code-index): pin retired pack inode in descriptor census - #4910
Merged
Merged
Conversation
Retention unlinks the retired pack while sibling tests open files on the same filesystem, so a reused inode number made the post-unlink holder census count an unrelated descriptor. Hold a pin on the pack for the whole test and exclude only that descriptor from the census. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ScriptedAlchemy
enabled auto-merge
November 16, 2026 20:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ordinary_retention_waits_for_active_pack_reads_and_leaves_no_idle_payload_handlesintermittently fails on Linux (left: 1, right: 0at the final holder census), e.g. on #4903's requiredTest Linuxcheck.The census matches
/proc/self/fdentries by(dev, ino)of the retired pack. After retention unlinks the pack, the kernel may reuse that inode number for a file opened by a concurrently running test in the same process, so an unrelated descriptor is counted.Fix
Test-only: hold a descriptor on the pack for the whole test so its inode stays allocated and its number cannot be reused, and exclude only that pin from the census. All four holder assertions keep their meaning.
Verification
Ran the test on Linux (rust:1.100.0-bookworm,
--cfg tokio_unstable): passes.🤖 Generated with Claude Code