Repository navigation
Fix Java nightly CDP imports and Ruby apt install in CI - #2940
Merged
Merged
Conversation
- [java] Use CDP v155 in the CDP examples. Nightly Selenium no longer includes v153. v155 is supported by both the stable and nightly builds. - [ci] Run apt-get update before installing Fluxbox in the Ruby workflow, so apt does not request package versions the mirror no longer has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
PR Summary by QodoFix Java nightly CDP imports and Ruby apt installation in CI
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history Previous reviewsReview updated until commit ac0e115 Results up to commit e21f117
|
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The examples pinned Chrome 153, which nightly Selenium no longer supports. Chrome 155 matches the v155 CDP imports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Code review by qodo was updated up to the latest commit ac0e115 |
Contributor
|
No code changes since the last review — review skipped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
CdpApiTestandNetworkTestnow importdevtools.v155instead ofdevtools.v153, the same version the .NET examples use. Only import lines change, so thegh-codeblockline ranges stay the same.CdpApiTestnow pins Chrome 155 instead of 153, to match the v155 imports.sudo apt-get updatebefore installing Fluxbox and the other packages.Motivation and Context
CdpApiTestcannot open a CDP session on Chrome 153. v155 is in both stable 4.51.0 and nightly.The two Java test classes pass locally against stable 4.51.0.
Types of changes
Checklist
🤖 Generated with Claude Code