Repository navigation
Bump Selenium to 4.52.0 and CDP to v156 in examples - #2956
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Summary by QodoBump Selenium examples to 4.52.0 and CDP examples to v156
AI Description
Diagram
High-Level Assessment
Files changed (15)
|
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code Review by Qodo
1. Grid example tests cannot start the server
|
| protected Uri GridUrl; | ||
| private Process _webserverProcess; | ||
| private const string ServerJarName = "selenium-server-4.51.0.jar"; | ||
| private const string ServerJarName = "selenium-server-4.52.0.jar"; |
There was a problem hiding this comment.
1. Grid example tests cannot start the server 🐞 Bug ≡ Correctness
The Grid launchers now pass selenium-server-4.52.0.jar to Java, but that artifact was not added alongside the existing 4.51.0 jar. When the .NET, JavaScript, Python, or Ruby Grid tests run from a checkout, server startup fails and the tests error or time out before exercising their examples.
Agent Prompt
## Issue description
The Grid launchers request a 4.52.0 server jar, but the repository contains only the 4.51.0 jar. Grid-backed examples cannot start their server.
## Fix Focus Areas
- examples/dotnet/SeleniumDocs/BaseTest.cs[20-20]
- examples/javascript/test/drivers/gridServer.js[6-6]
- examples/python/tests/conftest.py[159-159]
- examples/python/tests/conftest.py[217-217]
- examples/python/tests/conftest.py[295-295]
- examples/ruby/spec/drivers/remote_webdriver_spec.rb[10-10]
## Recommended Fix
Add the Selenium Server 4.52.0 jar at `examples/selenium-server-4.52.0.jar`, replacing the bundled 4.51.0 jar if appropriate, so every updated launcher resolves an existing artifact. Verify a Grid-backed test in each language.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Code review by qodo was updated up to the latest commit 358031b |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Code review by qodo was updated up to the latest commit 59da3c7 |
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Bumps Selenium to 4.52.0 and CDP to v156 in all code examples:
v155->v156, and the Chrome version they pin is now 156.examples/selenium-server-4.51.0.jaris replaced with 4.52.0.Python (
selenium==4.52.0) and Rubyselenium-devtools(0.156.0) were already bumped. Line counts did not change, sogh-codeblockranges stay the same.Motivation and Context
Keep the examples on the latest Selenium release.
Types of changes
Checklist
🤖 Generated with Claude Code