End all RT segments with 0x0d char

[antoniodgonzalez]

My car was only displaying the last segment of the RS text. After some testing I discovered that the 0x0d was needed to be sent every segment, as noted in the TODO.
I'm not sure if this is the best fix, feel free to suggest any changes.

[ShadowLight8]

@antoniodgonzalez I'll take a look at this over the weekend. When your car displays the RT text, does it show the entire last fragment? About how many characters does it display? I'm trying to think about how I can help test this with the radios I have.

There is also logic that flips the A/B flag back and forth with each fragment that could play into this.

Can you upload some debug logs of the engine while it's transmitting with your changes?

Out of curiosity, what car do you have?

[antoniodgonzalez]

Hi @ShadowLight8, I continued with more testing

With the original code, before the changes in this PR, this is the output of the engine log:

18:08:21 INFO Status - State 10 (expect 10) - Audio Peak 6 (target <= 14)
18:08:22 INFO Updating pending RDS Data: playlist=False, media=True
18:08:22 INFO PS ['PS123456', '78      ']
18:08:22 INFO RT ['Cancion 1 de 10                 ', 'Have Yourself a Merry Little Chr', 'istmas\r']

My car only displays the last part of both PS and RT:

I checked in another car and all the texts are displayed as expected. My car is a Tesla, it only displays the last segment (after around 16 secs). I read somewhere that the RDS implementation in Teslas is limited, but I don't know much about RDS.

After the changes in this PR, this is the output of the engine.

18:33:13 INFO Updating pending RDS Data: playlist=True, media=True
18:33:13 INFO PS ['PS123456', '78      ']
18:33:13 INFO RT ['Cancion 1 de 10                \r', 'Have Yourself a Merry Little Ch\r', 'ristmas\r']

I didn't realize that the PS was not changing (I used a single message), but it has the same problem. With this I get all the 3 RT messages.

Please, ask me for any additional info you may need or test I can make.

[antoniodgonzalez]

Hi @ShadowLight8,
I made some changes to send the 0x0d char in the RT, removing the padding spaces (if the message is below 64 chars).

Now my output is like:

INFO RT ['Cancion 1 de 10\r', 'Have Yourself a Merry Little Chr\r', ristmas\r']

This is what I understand is the expected behavior, as explained here: NRSC-4-B Standard

That said, this change was just for testing purposes, maybe the good change sould be applied to the engine, to append there the terminator char instead the padding. Probably this should affect also the other supported transmitter Si4713 (Just out of curiosity I ordered a Si4713).

Please, forget what I said previously aboug PS not changing. After more testing I see it is changing from time of time. Maybe this is intended with my car radio, as the PS is intended to be used for a static name.

[ShadowLight8]

@antoniodgonzalez Thanks for the follow up! I'm going to again this weekend to take a look 😄