Skip to content

Applying a release syncs the starter's skills, and the changelog check rejects a stale copy - #2309

Merged
marvin-bitterlich merged 1 commit into
mainfrom
ccr-efcafb6c-sxkls9-release-skills-sync
Nov 18, 2026
Merged

marvin-bitterlich merged 1 commit into
mainfrom
ccr-efcafb6c-sxkls9-release-skills-sync

Conversation

@marvin-bitterlich

Copy link
Copy Markdown
Contributor

Why?

examples/starter/.agents/skills/.shivaedev-skills.json records the @shivaedev/skills version its copy was synced from. Nothing updated it when a release bumped the package, so the starter's pnpm lint:skills failed on main after every skills release. #2308 synced it by hand to 0.9.1, and the release in #2296 moved the package to 0.9.2, so main is stale again today.

How?

pnpm releases apply already aligns the starter's package pins, pnpm pin and catalog through the repository's release hook. The hook now also runs the skills sync for examples/starter against packages/skills. It runs after the versions are bumped, so the manifest records the version the release produces.

pnpm changelog:check now runs the skills check for the starter, beside the pin checks. It is the same check as the starter's pnpm lint:skills: the recorded version, the selected skills and each copy's hash. A stale starter fails lint, the commit hook and CI, and the message names both repairs.

State pnpm changelog:check
Manifest records the current skills version, copies as synced passes
Manifest records an older version (main today) fails, names pnpm skills:sync and pnpm releases apply

The manifest on this branch is synced to 0.9.2; only its version line changed, because the copy already matched.

Two stories in script/release/syncedStarterSkills.spec.ts use the existing repository kit with one new trait: applying a release that bumps the skills package gives the starter the released instructions under the released version, and a starter left on its copy from before the release is rejected with the repair. Both fail without the hook and the check.

Decisions

  • The check lives in changelog:check, not in a new CI step. That is where the other starter alignment checks are, and it reaches lint, the commit hook, PR CI and publishing at once.
  • The scripts call @shivaedev/skills directly, so the root package gains it as a workspace dev dependency. No published package changes, so there is no changeset.
  • A starter that selects no skills is skipped. The fixtures of the other release stories have no shivaedevSkills field and stay as they are. The real starter's selection is proved by create-app's generatedSkills.spec.ts.
  • The check does not compare the copy with the workspace source between releases. A PR that edits a selected skill does not have to resync the starter; the next release does it.

Callouts

  • The release hook's type gives it only the file system, so the hook provides Effect's built-in POSIX Path for the sync. Widening the hook type would have changed @shivaedev/releases.
  • In this sandbox, 12 stories of the release pull request kit (pullRequest.spec.ts, pullRequestHold.spec.ts, releaseCoverage.spec.ts) time out at 30 s. The same 12 time out the same way on the unmodified scripts of main, so they do not come from this change, and the other 12 stories of those files pass. appliedRelease.slow.spec.ts, which applies a release on a copy of the real workspace and then runs changelog:check, did not run here. CI runs all of them.

Generated by Claude Code

…k rejects a stale copy

The starter's skills manifest recorded the @shivaedev/skills version of
the last manual sync, so every skills release left it one version behind
and the starter's `pnpm lint:skills` failed on main.

The release hook now runs the skills sync for examples/starter against
packages/skills after versions are bumped, and `pnpm changelog:check`
runs the skills check for it. A starter that selects no skills is left
alone. The manifest on main is synced to 0.9.2.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VjCSiB3Dk7BRBmjic6wFM5
@marvin-bitterlich
marvin-bitterlich added this pull request to the merge queue Nov 18, 2026
@tally-code-quality

Copy link
Copy Markdown

Coverage 92.0% (+0.1 pts)

No coverable lines added.

c675eff (merged onto ed99521) vs main at ed99521 · updated Nov 18, 15:34 UTC · Full report

Merged via the queue into main with commit 64d4061 Nov 18, 2026
20 checks passed
@marvin-bitterlich
marvin-bitterlich deleted the ccr-efcafb6c-sxkls9-release-skills-sync branch November 18, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants