Repository navigation
Applying a release syncs the starter's skills, and the changelog check rejects a stale copy - #2309
Merged
Conversation
…k rejects a stale copy The starter's skills manifest recorded the @shivaedev/skills version of the last manual sync, so every skills release left it one version behind and the starter's `pnpm lint:skills` failed on main. The release hook now runs the skills sync for examples/starter against packages/skills after versions are bumped, and `pnpm changelog:check` runs the skills check for it. A starter that selects no skills is left alone. The manifest on main is synced to 0.9.2. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjCSiB3Dk7BRBmjic6wFM5
marvin-bitterlich
enabled auto-merge
November 18, 2026 15:25
Coverage 92.0% (+0.1 pts)No coverable lines added.
|
marvin-bitterlich
deleted the
ccr-efcafb6c-sxkls9-release-skills-sync
branch
November 18, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
examples/starter/.agents/skills/.shivaedev-skills.jsonrecords the@shivaedev/skillsversion its copy was synced from. Nothing updated it when a release bumped the package, so the starter'spnpm lint:skillsfailed on main after every skills release. #2308 synced it by hand to 0.9.1, and the release in #2296 moved the package to 0.9.2, so main is stale again today.How?
pnpm releases applyalready aligns the starter's package pins, pnpm pin and catalog through the repository's release hook. The hook now also runs the skills sync forexamples/starteragainstpackages/skills. It runs after the versions are bumped, so the manifest records the version the release produces.pnpm changelog:checknow runs the skills check for the starter, beside the pin checks. It is the same check as the starter'spnpm lint:skills: the recorded version, the selected skills and each copy's hash. A stale starter fails lint, the commit hook and CI, and the message names both repairs.pnpm changelog:checkpnpm skills:syncandpnpm releases applyThe manifest on this branch is synced to 0.9.2; only its version line changed, because the copy already matched.
Two stories in
script/release/syncedStarterSkills.spec.tsuse the existingrepositorykit with one new trait: applying a release that bumps the skills package gives the starter the released instructions under the released version, and a starter left on its copy from before the release is rejected with the repair. Both fail without the hook and the check.Decisions
changelog:check, not in a new CI step. That is where the other starter alignment checks are, and it reaches lint, the commit hook, PR CI and publishing at once.@shivaedev/skillsdirectly, so the root package gains it as a workspace dev dependency. No published package changes, so there is no changeset.shivaedevSkillsfield and stay as they are. The real starter's selection is proved by create-app'sgeneratedSkills.spec.ts.Callouts
Pathfor the sync. Widening the hook type would have changed@shivaedev/releases.pullRequest.spec.ts,pullRequestHold.spec.ts,releaseCoverage.spec.ts) time out at 30 s. The same 12 time out the same way on the unmodified scripts of main, so they do not come from this change, and the other 12 stories of those files pass.appliedRelease.slow.spec.ts, which applies a release on a copy of the real workspace and then runschangelog:check, did not run here. CI runs all of them.Generated by Claude Code