Repository navigation
Fleet stops rebuilding the Board for work that did not change - #7
Merged
Merged
Conversation
A fresh read of an unchanged brief no longer invalidates the Board index, the index keeps the decoded settled catalogue and archive state until those files change, Fleet renders status and counts health only when its records change, and Fleet checks a snapshot's problems once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
After the memory fix in #6, the Fleet daemon still burned more than one CPU core on Platform's busy Board. A copy of that Board ran the daemon at 137% CPU, with its main thread busy 92% of the time, while no work was running.
The loop was not Fleet's own output.
fleet/health.jsonis not a Markdown file, so the Board watcher never sees it, andfleet/status.mdwas already written only when its bytes changed. The loop came from reads that acted like writes:Each reconciler pass paid for a full index rebuild, a full status render and a full area check, even when nothing had changed. A sweep over the done records took longer than the gap between scheduling writes, so it never drained.
How?
Each step now costs work only when its input changed.
fleet/status.mdand recounts health only when the store hands back different records. The store returns the same record object until its row changes, so identity is a cheap and exact test. A failed write leaves the status unpublished, so the next pass repairs it.Callouts
.board-archive.json.