Repository navigation
Remove Vitest thread settings that Vitest 4 ignores - #9153
Merged
Merged
Conversation
VITEST_MIN_THREADS and VITEST_MAX_THREADS have had no effect since the upgrade to Vitest 4, which reads only VITEST_MAX_WORKERS. The unit-test jobs keep running with Vitest's default worker count, as they have since that upgrade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
craigmichaelmartin
requested review from
dbuhon,
dmerand,
durga256 and
isaacroldan
November 17, 2026 18:34
dmerand
approved these changes
Nov 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
tests-pr.ymlandtests-main.ymlsetVITEST_MIN_THREADSandVITEST_MAX_THREADSfor the unit tests. Vitest 4 ignores both and reads onlyVITEST_MAX_WORKERS, so they have had no effect since the upgrade to Vitest 4, and they suggest a cap of 4 that isn't applied.WHAT is this pull request doing?
Removes the two variables from both workflows, with no replacement. The unit-test jobs keep Vitest's default worker count, one per CPU less one, which is what they have run with since that upgrade: 3 workers on the Linux and Windows runners and 2 on macOS.
How to manually test your changes?
In a checkout with dependencies installed, search Vitest's build:
grep -rl VITEST_MAX_THREADS node_modules/vitest/distfinds nothing, andgrep -rl VITEST_MAX_WORKERS node_modules/vitest/distfinds the file that reads it.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add🤖 Generated with Claude Code