Skip to content

Remove Vitest thread settings that Vitest 4 ignores - #9153

Merged
craigmichaelmartin merged 2 commits into
mainfrom
remove-unused-vitest-thread-vars
Nov 18, 2026
Merged

craigmichaelmartin merged 2 commits into
mainfrom
remove-unused-vitest-thread-vars

Conversation

@craigmichaelmartin

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

tests-pr.yml and tests-main.yml set VITEST_MIN_THREADS and VITEST_MAX_THREADS for the unit tests. Vitest 4 ignores both and reads only VITEST_MAX_WORKERS, so they have had no effect since the upgrade to Vitest 4, and they suggest a cap of 4 that isn't applied.

WHAT is this pull request doing?

Removes the two variables from both workflows, with no replacement. The unit-test jobs keep Vitest's default worker count, one per CPU less one, which is what they have run with since that upgrade: 3 workers on the Linux and Windows runners and 2 on macOS.

How to manually test your changes?

In a checkout with dependencies installed, search Vitest's build: grep -rl VITEST_MAX_THREADS node_modules/vitest/dist finds nothing, and grep -rl VITEST_MAX_WORKERS node_modules/vitest/dist finds the file that reads it.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

🤖 Generated with Claude Code

VITEST_MIN_THREADS and VITEST_MAX_THREADS have had no effect since the upgrade to Vitest 4,
which reads only VITEST_MAX_WORKERS. The unit-test jobs keep running with Vitest's default
worker count, as they have since that upgrade.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@craigmichaelmartin
craigmichaelmartin requested a review from a team as a code owner November 17, 2026 18:33
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Nov 17, 2026
@craigmichaelmartin
craigmichaelmartin added this pull request to the merge queue Nov 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 18, 2026
@craigmichaelmartin
craigmichaelmartin added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 72c24bb Nov 18, 2026
29 checks passed
@craigmichaelmartin
craigmichaelmartin deleted the remove-unused-vitest-thread-vars branch November 18, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants