Repository navigation
Release from stable branches, and publish only the versions a push changed - #9165
Merged
Merged
Conversation
A release whose publish failed was finished by the next push, from that push's newer tree. The check now counts only packages whose version the push changed, or that it made public, and the publish job marks every other package private for the run. A version an earlier push brought is finished by re-running that push's run, or by the new `release` option of a manual run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A manual run published every unpublished version at the branch's head, so a version whose push was followed by later commits went out from the newer tree. It now publishes only the versions the head commit changed against its first parent, and fails with the reason otherwise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
main no longer publishes releases: its check fails when a version on it is missing from npm, and releases ship from stable/* through a merged Version Packages pull request. The publish job checks that the merge's tree is the pull request head's, version-packages refuses a version npm already has, and a new manual workflow builds the release tarball of a given commit for testing. The stable-branch creation steps are removed: Dev Experience creates stable/X.Y by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A merge commit whose files equal its second parent's proves the line didn't move, not that the merged head was the tested pull request: a hand-made merge pushed directly also passes. The publish job now also requires the commit to be the merge of a pull request from changeset-release/<line> into the line, with that head. npm reads are retried so a registry blip doesn't read as missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dmerand
approved these changes
Nov 18, 2026
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Releases now ship from
stable/X.Ybranches: a Dev Experience member cutsstable/X.Yfrom a greenmaincommit, the existing workflow opens its version bump there, QA tests that pull request's head, and merging it publishes. That gives every release a fixed, tested commit. The workflow also needs to stop two existing ways for untested code to reach npm:maincould publish too, so a version bump landing onmainwould publish whatevermainheld.WHAT is this pull request doing?
stable/*publishes. Onmain, Check for unpublished versions fails when any version onmainis missing from npm, and Publish to npm never runs.package.jsonwith the push's previous commit and counts a package only if the push changed its version or made it public. Publish to npm marks every other package private for the run.release, publishes the versions the branch's head commit changed against its first parent, for a push that started no run. If the head commit changed no version, it fails and says why.changeset-release/stable/X.Y. Its files must also be exactly that pull request head's. If the branch moved after the pull request was made, or the commit isn't that merge, it fails.maingot the previous release back.release-qa-package.yml). Run by hand with a commit SHA, which must be the head of a branch here. It builds the@shopify/clitarball the way the release does and uploads it as an artifact. It has read-only permissions, no secrets and no environment, and publishes nothing.stable/X.Yafter an X.Y.0 release, and corrects comments that described an npm-release approval step that no longer exists.The same change is ready for
stable/5.0andstable/4.9, because each branch publishes with its own copy of this workflow.How to manually test your changes?
mainshows every package "is on npm" and skips Publish to npm.shopify-cli-<sha>, andgh run download <run-id> -R Shopify/cli -n shopify-cli-<sha>fetches it.Version Packages - stable/X.Ypull request with a merge commit while the branch is still at the head's parent. Publish to npm logs "Publishing the files of ".🤖 Generated with Claude Code