Skip to content

Fix the branch-head check in the Release QA package workflow - #9170

Merged
craigmichaelmartin merged 1 commit into
mainfrom
release-qa-package-branch-check
Nov 18, 2026
Merged

craigmichaelmartin merged 1 commit into
mainfrom
release-qa-package-branch-check

Conversation

@craigmichaelmartin

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The Release QA package workflow rejected every valid SHA. Its branch-head check piped git ls-remote through cut into grep -qx. grep -q exits at its first match, so cut got a broken pipe, and under set -o pipefail the pipeline failed: https://github.com/Shopify/cli/actions/runs/44370610560.

WHAT is this pull request doing?

Reads the list of branch heads into a variable first, then searches it.

How to manually test your changes?

This branch's version of the workflow, run on stable/5.0's head, passed and uploaded shopify-cli-5.0.2.tgz: https://github.com/Shopify/cli/actions/runs/44370771788. Its file list matches the published @shopify/cli@5.0.2 tarball.

🤖 Generated with Claude Code

Under pipefail, grep -q exits at its first match, the upstream cut gets a broken pipe, and the
pipeline fails, so every valid SHA was rejected. The check now reads the branch heads first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@craigmichaelmartin
craigmichaelmartin requested a review from a team as a code owner November 18, 2026 18:42
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Nov 18, 2026
@craigmichaelmartin
craigmichaelmartin added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 25ffeb5 Nov 18, 2026
30 checks passed
@craigmichaelmartin
craigmichaelmartin deleted the release-qa-package-branch-check branch November 18, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants