Repository navigation
Fix the branch-head check in the Release QA package workflow - #9170
Merged
Merged
Conversation
Under pipefail, grep -q exits at its first match, the upstream cut gets a broken pipe, and the pipeline fails, so every valid SHA was rejected. The check now reads the branch heads first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dmerand
approved these changes
Nov 18, 2026
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The Release QA package workflow rejected every valid SHA. Its branch-head check piped
git ls-remotethroughcutintogrep -qx.grep -qexits at its first match, socutgot a broken pipe, and underset -o pipefailthe pipeline failed: https://github.com/Shopify/cli/actions/runs/44370610560.WHAT is this pull request doing?
Reads the list of branch heads into a variable first, then searches it.
How to manually test your changes?
This branch's version of the workflow, run on
stable/5.0's head, passed and uploadedshopify-cli-5.0.2.tgz: https://github.com/Shopify/cli/actions/runs/44370771788. Its file list matches the published@shopify/cli@5.0.2tarball.🤖 Generated with Claude Code