Skip to content

Update development dependencies to address security advisories - #185

Open
mfecteauleclerc wants to merge 1 commit into
Shopify:masterfrom
mfecteauleclerc:security/update-dependencies
Open

mfecteauleclerc wants to merge 1 commit into
Shopify:masterfrom
mfecteauleclerc:security/update-dependencies

Conversation

@mfecteauleclerc

Copy link
Copy Markdown

Summary

Conservative, in-series security bumps for development/test-only dependencies across the root Gemfile.lock and all Appraisal lockfiles. The gem's only runtime dependency (retriable) is not affected by any advisory.

Gem Before After Advisories fixed
activerecord / activesupport 8.0.1 / 7.2.2.1 8.0.5.2 / 7.2.4 CVE-2025-55193 (ANSI escape injection in AR logging), CVE-2026-33169 (ReDoS in number_to_delimited), CVE-2026-33170 (XSS in SafeBuffer#%), CVE-2026-33176 (DoS in number helpers), GHSA-8474-xrp6-wh69 (DoS in safe_constantize)
concurrent-ruby 1.3.5 1.3.8 CVE-2026-54904 (AtomicReference#update livelock), CVE-2026-54905 (read-count overflow), CVE-2026-54906 (wrong-thread write release)
trilogy 2.8.1 / 2.9.0 2.13.3 GHSA-744p-w4gc-m3gh (SQL injection through Trilogy#escape with multibyte encodings)
uri 1.0.2 1.1.2 CVE-2025-52619 → CVE-2025-27221 (userinfo leakage), CVE-2025-61594 (URI credential leakage bypass)

Notes

  • Appraisals pins updated to the patched releases (activerecord 7.2.4 / 8.0.5.2); the activerecord_head appraisal keeps tracking Rails main and only its transitive vulnerable gems were bumped.
  • All locked versions support the CI Ruby floor (3.1 for the 7.2 appraisal, 3.2 for 8.0/head; each version's required_ruby_version verified).
  • Rails stays within the same minor series (8.0.x / 7.2.x) to keep the change conservative; no breaking changes to the gem's runtime.

Test

Full suite run locally (activerecord 8.0 appraisal, mysql2 adapter, MySQL 8.0):

  • bundle exec rake specs → unit: 133 runs, 0 failures, 0 errors; integration: 102 runs, 0 failures, 0 errors

Found via bundle-audit (ruby-advisory-db 2026-11-09).

- activerecord/activesupport: 8.0.1 -> 8.0.5.2, 7.2.2.1 -> 7.2.4
  (CVE-2025-55193, CVE-2026-33169, CVE-2026-33170, CVE-2026-33176,
  GHSA-8474-xrp6-wh69)
- concurrent-ruby: 1.3.5 -> 1.3.8
  (CVE-2026-54904, CVE-2026-54905, CVE-2026-54906)
- trilogy: 2.8.1/2.9.0 -> 2.13.3 (GHSA-744p-w4gc-m3gh)
- uri: 1.0.2 -> 1.1.2 (CVE-2025-25221 in lockfiles is CVE-2025-27221,
  CVE-2025-61594)

These are development/test-only dependencies; the gem's only runtime
dependency (retriable) is not affected. Bumps stay within the same
minor series (Rails 8.0.x / 7.2.x) and all locked versions support the
CI Ruby floor (3.1 for the 7.2 appraisal, 3.2 for 8.0).
@mfecteauleclerc

Copy link
Copy Markdown
Author

Note on the 8 failing ruby = head jobs: they fail during dependency installation, before any test runs:

An error occurred while installing byebug (11.1.3), and Bundler cannot continue.

byebug 11.1.3 (the latest release, unchanged in this PR — its lockfile entry is identical to master) cannot compile its native extension against the current ruby-head snapshot (4.1.0+6). ruby-head has moved past the point where byebug builds; the last full green run on this repo (PR #183, June 2026) predates that. This is expected to affect master equally today and is unrelated to the security bumps — every job on a supported Ruby (3.1/3.2/3.3), both adapters (mysql2/trilogy), both MySQL versions (5.7/8.0), and all three appraisal targets passes.

byebug has no fixed release available, so a durable fix needs a maintainer decision (e.g. drop byebug from the dev dependencies or make the require 'byebug' in spec/test_helper.rb conditional) and is out of scope for this dependency-security change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant