Repository navigation
Enable OIDC npm publishing on remote-ui - #746
Merged
Merged
Conversation
Replace the legacy npm token with GitHub Actions OIDC permissions and provenance, following the publishing setup on main. Keep the existing Node 24.19.0 pin, whose bundled npm 11.17.0 supports trusted publishing, and pin the Changesets action and CLI to compatible releases. Add repository metadata to every publishable package so npm provenance identifies Shopify/remote-dom correctly. Preserve the Yarn release build and GitHub token used for release pull requests, tags, and releases. Regenerate the lockfile without upgrading unrelated dependency selectors.
Contributor
|
We detected some changes in |
Remove setup-node's registry-url input because it generates an npmrc NODE_AUTH_TOKEN placeholder that Yarn 1.19.2 cannot resolve when unset. The default npm registry is sufficient for OIDC publishing. Restore the existing Changesets CLI dependency and exact original lockfile. CLI 2.25.2 already delegates publishing to npm and skips profile/2FA checks in CI, so its upgrade is unnecessary for npm trusted publishing.
robin-drexler
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable npm trusted publishing for the legacy
remote-uibranch, following the publishing configuration onmain.id-token: write, replace the npm secret with an emptyNPM_TOKEN, and enable provenance.@changesets/cli2.25.2 resolution and original lockfile. The CLI already delegates publishing to npm and skips profile/2FA checks in CI; OIDC authentication is handled by npm.registry-urlto avoid generating an unresolved${NODE_AUTH_TOKEN}placeholder that breaks Yarn 1.19.2; npm defaults to npmjs.Shopify/remote-domcorrectly.Verification
git diff --checkpassed.registry-url, the unchanged lockfile, and package repository metadata. Yarn starts successfully withNODE_AUTH_TOKENunset.Publishing prerequisite
Each package being released must have an npm trusted publisher configured for organization Shopify, repository remote-dom, and workflow filename changesets.yml, with direct
npm publishpermitted. This PR does not change npm account/package settings, and live OIDC authentication has not been tested.