Skip to content

Enable OIDC npm publishing on remote-ui - #746

Merged
andrewiggins merged 2 commits into
remote-uifrom
remote-ui-oidc-publishing
Oct 30, 2026
Merged

andrewiggins merged 2 commits into
remote-uifrom
remote-ui-oidc-publishing

Conversation

@andrewiggins

@andrewiggins andrewiggins commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Enable npm trusted publishing for the legacy remote-ui branch, following the publishing configuration on main.

  • Give the Changesets job id-token: write, replace the npm secret with an empty NPM_TOKEN, and enable provenance.
  • Pin the Changesets action to v1.9.0 while keeping the existing @changesets/cli 2.25.2 resolution and original lockfile. The CLI already delegates publishing to npm and skips profile/2FA checks in CI; OIDC authentication is handled by npm.
  • Keep the existing Node 24.19.0 pin: its bundled npm 11.17.0 exceeds the npm 11.5.1 minimum for trusted publishing. Omit setup-node's registry-url to avoid generating an unresolved ${NODE_AUTH_TOKEN} placeholder that breaks Yarn 1.19.2; npm defaults to npmjs.
  • Add the current repository URL and package directories to all 12 publishable package manifests so provenance identifies Shopify/remote-dom correctly.
  • Preserve the Yarn prerelease build and the GitHub token used to create release PRs, tags, and releases. Fetch full Git history and avoid persisting checkout credentials.

Verification

  • Frozen-lockfile dependency install passed.
  • Build and type-check passed.
  • All 150 tests across 15 suites passed.
  • Formatting and git diff --check passed.
  • Workflow assertions validated branch triggers, permissions, action SHA pins, absence of registry-url, the unchanged lockfile, and package repository metadata. Yarn starts successfully with NODE_AUTH_TOKEN unset.
  • A mock npm executable verified that the retained Changesets CLI 2.25.2 invokes npm publishing for all 12 packages with an empty npm token, public access, and provenance enabled, without querying profile authentication. No real publishing, Git tags, or tracked-file changes occurred during that check.

Publishing prerequisite

Each package being released must have an npm trusted publisher configured for organization Shopify, repository remote-dom, and workflow filename changesets.yml, with direct npm publish permitted. This PR does not change npm account/package settings, and live OIDC authentication has not been tested.

Replace the legacy npm token with GitHub Actions OIDC permissions and
provenance, following the publishing setup on main. Keep the existing
Node 24.19.0 pin, whose bundled npm 11.17.0 supports trusted publishing,
and pin the Changesets action and CLI to compatible releases.

Add repository metadata to every publishable package so npm provenance
identifies Shopify/remote-dom correctly. Preserve the Yarn release build
and GitHub token used for release pull requests, tags, and releases.
Regenerate the lockfile without upgrading unrelated dependency selectors.
@github-actions

Copy link
Copy Markdown
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory.
If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

Remove setup-node's registry-url input because it generates an npmrc
NODE_AUTH_TOKEN placeholder that Yarn 1.19.2 cannot resolve when unset.
The default npm registry is sufficient for OIDC publishing.

Restore the existing Changesets CLI dependency and exact original lockfile.
CLI 2.25.2 already delegates publishing to npm and skips profile/2FA checks
in CI, so its upgrade is unnecessary for npm trusted publishing.
@andrewiggins
andrewiggins merged commit dc6f786 into remote-ui Oct 30, 2026
5 checks passed
@andrewiggins
andrewiggins deleted the remote-ui-oidc-publishing branch October 30, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants