Skip to content

Return the response from BatchingRemoteConnection.call() - #747

Open
zacyungblut wants to merge 1 commit into
Shopify:mainfrom
zacyungblut:zacyungblut-patch-1
Open

zacyungblut wants to merge 1 commit into
Shopify:mainfrom
zacyungblut:zacyungblut-patch-1

Conversation

@zacyungblut

Copy link
Copy Markdown

Fixes #742

BatchingRemoteConnection.call() invoked the wrapped connection's call() but dropped its return value, so callers always received undefined even though RemoteConnection.call() resolves with the remote method's response.

This forwards the return value and annotates the method with the same unknown return type as RemoteConnection.call().

@zacyungblut

Copy link
Copy Markdown
Author

I've signed the CLA!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BatchingRemoteConnection.call() drops the return value

1 participant