Skip to content

Correct Gabon default currency to XAF - #684

Open
trekkie4life wants to merge 1 commit into
Shopify:mainfrom
trekkie4life:fix/gabon-currency-xaf
Open

trekkie4life wants to merge 1 commit into
Shopify:mainfrom
trekkie4life:fix/gabon-currency-xaf

Conversation

@trekkie4life

@trekkie4life trekkie4life commented Nov 18, 2026 •

Copy link
Copy Markdown

What are you trying to accomplish?

Correct Gabon's default currency to XAF (Central African CFA franc). Worldwide currently returns XOF (West African CFA franc) for Gabon, but ISO 4217 list one lists XAF, the same currency as Cameroon.

What approach did you choose and why?

  • Change only currency: XOF to currency: XAF in data/regions/GA.yml.
  • XOF is kept, and Senegal continues to use it. This corrects one country's mapping; it does not replace or remove a currency.
  • Use the existing XAF definition. No CLDR update or new currency definition is needed.

Testing

The regression test uses real country and currency data. It checks that Gabon and Cameroon return XAF, Senegal returns XOF, and Worldwide.currency(code: "XOF") still returns XOF.

With the old Gabon mapping, the region suite fails with expected XAF, actual XOF. With the correction, the combined region, currency, and data-consistency suites pass: 180 tests, 0 failures or errors. bundle exec rubocop also passes with no offenses.

Checklist

  • I have added a CHANGELOG entry for this change

@trekkie4life
trekkie4life marked this pull request as ready for review November 18, 2026 04:07
@trekkie4life
trekkie4life requested a review from a team as a code owner November 18, 2026 04:07
@trekkie4life

Copy link
Copy Markdown
Author

Hi! Who would own the follow-up PR to update the gem version Core uses?

@trekkie4life
trekkie4life force-pushed the fix/gabon-currency-xaf branch from c77e6c4 to 2dfb575 Compare November 18, 2026 17:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant