Repository navigation
Correct Gabon default currency to XAF - #684
Open
trekkie4life wants to merge 1 commit into
Open
trekkie4life wants to merge 1 commit into
trekkie4life wants to merge 1 commit into
Conversation
Author
|
Hi! Who would own the follow-up PR to update the gem version Core uses? |
trekkie4life
force-pushed
the
fix/gabon-currency-xaf
branch
from
November 18, 2026 17:06
c77e6c4 to
2dfb575
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Correct Gabon's default currency to XAF (Central African CFA franc). Worldwide currently returns XOF (West African CFA franc) for Gabon, but ISO 4217 list one lists XAF, the same currency as Cameroon.
What approach did you choose and why?
currency: XOFtocurrency: XAFindata/regions/GA.yml.Testing
The regression test uses real country and currency data. It checks that Gabon and Cameroon return XAF, Senegal returns XOF, and
Worldwide.currency(code: "XOF")still returns XOF.With the old Gabon mapping, the region suite fails with expected XAF, actual XOF. With the correction, the combined region, currency, and data-consistency suites pass: 180 tests, 0 failures or errors.
bundle exec rubocopalso passes with no offenses.Checklist