Repository navigation
feat(reader): integrate precise footer across landing pages - #72
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
reader | e21c70a | Oct 08 2026, 02:17 PM |
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader’s selected C footer now has compact native capture, same-origin licensed font mirrors and verified original folio-art provenance across the landing, FAQ and changelog. The sample page’s “Open my library” link uses the existing gray1 foreground on its near-white accent button, correcting the white-on-white label. The source outside this exact owner-approved accessibility class change retains existing app/extension handlers, themes and Review Pack banner removal.
Includes the owner-approved existing transitive security overrides and native regenerated lockfile: sharp0.35.5, shell-quote1.11.0 and source-map-js1.2.2. No direct production dependency is added; lock importers and the existing http-cache-semantics patch are unchanged.
Validation: managed frozen pnpm10.33.2 install; focused changed-file Biome check and complete native quality passed (176 app tests,20 extension tests, code-health/docs gates and landing/app/extension builds;0critical/high/unexpected dependencies). All18 reviewed source file hashes remain stable after checks, including the generated homepage whose change is confined to the existing closing host. Actual built landing/FAQ/changelog and anonymous sample/library at390/768/1440 returned200 with0overflow; edited assistant URLs, required invalid-email validation/unchecked consent, feedback Escape/focus and studio keyboard scrolling/exclusion passed. Sample CTA contrast measured19.06:1 normally and15.68:1 on hover at all three widths, and keyboard Enter reached the native library. All44 actual loaded compiled app URLs were independently fetched and byte-matched to the fresh build. Paired actual rendered review, separate pinned iteration/final advisory scans24 and the final design-workflow check passed.
Exact candidate CI37791154952 passed every native/frozen/quality and local-library/guest-PDF/account-PDF/account-notes step: https://github.com/Significant-Hobbies/reader/actions/runs/37791154952 . Cloudflare’s candidate build check passed. Exact merged-main CI37791659045 passed. Clean-main guard6/6 and existing native production workflow37792374222 passed. Worker versione6259220-2894-428f-a66f-0e075066fd32 has exact merged SHA4d48c64431d6df7a53c50ffa071bb60fbeceeb1f at100% traffic; public five routes×390/768/1440, CTA contrast/handoff, footer controls and original-art/font/runtime/44compiledasset byte proof plus final design check passed. No authenticated Reader workflow or whole-product owner acceptance is claimed.
Tracks #71.